Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collect Zentao issue-repo-commit from DB #8185

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

usharerose
Copy link
Contributor

@usharerose usharerose commented Nov 7, 2024

Summary

Collect issue-repo-commits data from database directly instead of APIs, since APIs have break changes for 18.13 which would not provide revision history.

Collecting data for an issue is with the following steps:

  1. get relevant revisions of an issue from zt_action filtered by action = 'gitcommited', extra stores first-ten characters of complete revision.
  2. get related repository info from zt_repohistory and zt_repo

Does this close any open issues?

No

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 7, 2024
@usharerose usharerose marked this pull request as draft November 7, 2024 04:22
@dosubot dosubot bot added component/plugins This issue or PR relates to plugins pr-type/feature-development This PR is to develop a new feature labels Nov 7, 2024
@usharerose usharerose force-pushed the feat-db-issue-commits branch 9 times, most recently from 8ce939c to 88a5e7e Compare November 8, 2024 08:24
@usharerose usharerose force-pushed the feat-db-issue-commits branch from 88a5e7e to d6d5647 Compare November 13, 2024 01:44
@usharerose usharerose marked this pull request as ready for review November 13, 2024 07:34
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 13, 2024
@usharerose usharerose changed the title feat: collect Zentao Story-Repo-Commit from DB feat: collect Zentao issue-repo-commit from DB Nov 13, 2024
if err != nil {
return nil, err
}
blob, _ := json.Marshal(data.Options.GetParams())
Copy link
Contributor

@d4x1 d4x1 Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the second return value should not be ignored. You'd better check it. It's an advice.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 14, 2024
@d4x1 d4x1 merged commit 89cdcba into apache:main Nov 14, 2024
12 checks passed
usharerose added a commit to usharerose/incubator-devlake that referenced this pull request Nov 21, 2024
* feat: collect Zentao Story-Repo-Commit from DB

* feat: collect Zentao bug and task related repo commits from DB
d4x1 pushed a commit that referenced this pull request Nov 22, 2024
* feat: collect Zentao Story-Repo-Commit from DB

* feat: collect Zentao bug and task related repo commits from DB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer pr-type/feature-development This PR is to develop a new feature size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants