Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deployment name too long when commits are too many #8024

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix: deployment name too long when commits are too many #8024

merged 1 commit into from
Sep 10, 2024

Conversation

klesh
Copy link
Contributor

@klesh klesh commented Sep 10, 2024 •
edited
Loading

Summary

Avoid the auto-generated cicd_deployment.name getting too long
when then number of commits are too high

Does this close any open issues?

Closes #7943

Screenshots

image

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. component/plugins This issue or PR relates to plugins pr-type/bug-fix This PR fixes a bug labels Sep 10, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 10, 2024
@d4x1 d4x1 merged commit 054b2f5 into main Sep 10, 2024
22 checks passed
@d4x1 d4x1 deleted the bugfix-7943-deployment-name-toolong branch September 10, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4x1 d4x1 d4x1 approved these changes

Assignees
No one assigned
Labels
component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer pr-type/bug-fix This PR fixes a bug size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
2 participants
@klesh @d4x1