Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configui): fix enableGraphql #6391

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Nov 3, 2023

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
Make enableGraphql works as expected: If a github connection disable graph ql, when user opens the config page, its value should be false.

Does this close any open issues?

Closes N/A

Screenshots

Include any relevant screenshots here.
image

Other Information

Any other information that is important to this PR.

Copy link
Member

@mintsweet mintsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mintsweet mintsweet merged commit 3ce19a6 into apache:main Nov 3, 2023
@d4x1 d4x1 deleted the lw-f-1102 branch November 3, 2023 02:16
@d4x1 d4x1 added the pr-type/bug-fix This PR fixes a bug label Nov 6, 2023
@d4x1 d4x1 added this to the v0.20 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-type/bug-fix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants