Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zentao): check db url when testing connections #6258

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Oct 16, 2023

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?

  1. Add db url field when testing connections for zentao plugin.
  2. Fix timeout param when checking db url.

Does this close any open issues?

Closes #5929

Screenshots

Include any relevant screenshots here.
correct db url
image

wrong db url
image

Other Information

Any other information that is important to this PR.

@d4x1 d4x1 requested review from klesh and mintsweet October 16, 2023 13:24
mintsweet
mintsweet previously approved these changes Oct 17, 2023
Copy link
Member

@mintsweet mintsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

backend/core/runner/db.go Outdated Show resolved Hide resolved
@klesh klesh merged commit ee1b60e into apache:main Oct 17, 2023
11 checks passed
@d4x1 d4x1 deleted the lw-fix-zentao-test-api branch October 17, 2023 08:36
sandesvitor pushed a commit to sandesvitor/incubator-devlake that referenced this pull request Oct 19, 2023
* feat(zentao): check db url when testing connections

* fix(zentao): remove test codes

* fix(zentao): remove test codes
@d4x1 d4x1 added the pr-type/bug-fix This PR fixes a bug label Oct 26, 2023
abeizn added a commit that referenced this pull request Nov 24, 2023
* feat: Opsgenie plugin implementation

* fix(lint): lint with gofmt

* refactor(lint): removing unused config-ui files

* feat(task): changed incident collector to accept incremental collection

* fix(config-ui): adjust the params for bp add connection (#6241)

* refactor: removed unused code (#6243)

* refactor(config-ui): remove content about user info (#6245)

* fix(azure): fix 400 error when cloing azure repos (#6246)

* fix: normalize_bp_settings throws error (#6249)

* fix: normalize_bp_settings throws error

* fix: pg ci

* fix: pg ci (#6252)

* fix(gitlab): fix incremental deployment collector (#6254)

* fix(gitlab): fix incremental deployment collector

* fix(gitlab): rollback to full collector

* refactor(gitlab): remove unused codes

* fix(gitlab): collect deployment incrementally

* fix: modify _tool_jira_issue_relationships primary key (#6253)

* fix: modify _tool_jira_issue_relationships primary key

* fix: ci lint

* feat(pagerduty): search remote scope by keyword (#6255)

* feat(pagerduty): search remote scope by keyword

* feat(pagerduty): add `createdAt` field

* refactor(impl): refactoring impl.go and service model

* refactor(comment): removing comment from incident collector

* feat(task): added GetCreated function

* feat(zentao): check db url when testing connections (#6258)

* feat(zentao): check db url when testing connections

* fix(zentao): remove test codes

* fix(zentao): remove test codes

* fix(configui): tagsLimit should be a number (#6261)

* fix(check): fixing lint in config-ui

* refactor(newline): adding removed newline

* fix(config-ui): removed old plugin type

* refactor(config-ui): remove type inheritance from opsgenieconfig

* style(config-ui): update icon with icon.svg

---------

Co-authored-by: 青湛 <[email protected]>
Co-authored-by: Klesh Wong <[email protected]>
Co-authored-by: Lynwee <[email protected]>
Co-authored-by: abeizn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-type/bug-fix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Plugin Zentao] wrong connection's property will not cause failed test
3 participants