Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cicd metrics added to github dashboard #6213

Merged
merged 7 commits into from
Oct 18, 2023
Merged

cicd metrics added to github dashboard #6213

merged 7 commits into from
Oct 18, 2023

Conversation

en-henciso
Copy link
Contributor

@en-henciso en-henciso commented Oct 10, 2023 •
edited
Loading

Summary

Include CICD pipeline stats to github dashboard

Does this close any open issues?

Closes #6101

Screenshots

Screenshot 2023-10-10 at 4 18 21 PM

@klesh
Copy link
Contributor

klesh commented Oct 11, 2023

@Startrekzky @ZhangNing10 Please take a look at this, thanks

@klesh klesh requested a review from Startrekzky October 11, 2023 05:46
ZhangNing10
ZhangNing10 requested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@ZhangNing10 ZhangNing10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of uid not found issue, kindly use "datasource": "mysql" instead of using type and uid

@Startrekzky
Copy link
Contributor

Hi @en-henciso , the linter failed. Please amend your commit message to follow the conventional commits guidelines. Thank you.

Startrekzky
Startrekzky requested changes Oct 12, 2023
View reviewed changes
grafana/dashboards/GitHub.json Outdated Show resolved Hide resolved
grafana/dashboards/GitHub.json Outdated Show resolved Hide resolved
@Startrekzky Startrekzky mentioned this pull request Oct 12, 2023
Merged
@en-henciso
datasource and uid changed
b12cbd3 
Signed-off-by: Hollman Enciso <[email protected]>
Startrekzky
Startrekzky requested changes Oct 16, 2023
View reviewed changes
grafana/dashboards/GitHub.json Outdated Show resolved Hide resolved
@en-henciso
feat(grafana): cicd metrics added to github dashboard
20abc19 
cicd metrics missing on github dashboard

apache#6101
Startrekzky
Startrekzky reviewed Oct 17, 2023
View reviewed changes
grafana/dashboards/GitHub.json Outdated
@@ -2227,6 +3293,30 @@
"skipUrlSync": false,
"sort": 0,
"type": "query"
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @en-henciso , I realized that there was already a repo_id variable. You can delete the following part and it won't affect the dashboard.

@en-henciso
feat(grafana): cicd metrics added to github dashboard
73f525d 
cicd metrics missing from github dashboard

apache#6101
Startrekzky
Startrekzky approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@Startrekzky Startrekzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Startrekzky Startrekzky merged commit 6307f12 into apache:main Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhangNing10 ZhangNing10 ZhangNing10 requested changes

@Startrekzky Startrekzky Startrekzky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][GitHub] CICD grafana stats
4 participants
@en-henciso @klesh @Startrekzky @ZhangNing10