Skip to content

refactor(zentao): add custom types OperatedBy and StringFloat64 to simplify codes#6188

Merged
klesh merged 3 commits intoapache:mainfrom
merico-ai:lw-zentao-custom-fieldtype
Oct 8, 2023
Merged

refactor(zentao): add custom types OperatedBy and StringFloat64 to simplify codes#6188
klesh merged 3 commits intoapache:mainfrom
merico-ai:lw-zentao-custom-fieldtype

Conversation

@d4x1
Copy link
Copy Markdown
Contributor

@d4x1 d4x1 commented Oct 7, 2023

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?

  1. The progress field in response of zentao's api is a string or a float, at fix(zentao): fix progress field when configurating scopes #6089 we add a progressRes field to receive this field and convert it into progress(float64).
  2. So do ClosedBy and CanceledBy fields.

Does this close any open issues?

Closes None

Screenshots

Include any relevant screenshots here.
The main branch cannot running, so test is on the way.

Other Information

Any other information that is important to this PR.

@d4x1 d4x1 requested review from abeizn and klesh October 7, 2023 09:57
@d4x1
Copy link
Copy Markdown
Contributor Author

d4x1 commented Oct 7, 2023

Here is an example for closedBy field:

{
    "closedBy": {
        "id": 1,
	"account": "admin",
	"avatar": "",
	"realname": "admin"
    },
    "others...": ""
}

Comment thread backend/core/models/common/string_float64.go
@klesh klesh merged commit d58803b into apache:main Oct 8, 2023
@d4x1 d4x1 added pr-type/bug-fix This PR fixes a bug pr-type/feature-development This PR is to develop a new feature type/refactor This issue is to refactor existing code pr-type/refactor This PR refactors existing features and removed pr-type/bug-fix This PR fixes a bug pr-type/feature-development This PR is to develop a new feature type/refactor This issue is to refactor existing code labels Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-type/refactor This PR refactors existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants