Skip to content

refactor: gitlab adopts ds_helper#6173

Merged
abeizn merged 10 commits intoapache:mainfrom
merico-ai:kw-5519-gitlab-adopts-dshelper
Oct 8, 2023
Merged

refactor: gitlab adopts ds_helper#6173
abeizn merged 10 commits intoapache:mainfrom
merico-ai:kw-5519-gitlab-adopts-dshelper

Conversation

@klesh
Copy link
Copy Markdown
Contributor

@klesh klesh commented Sep 28, 2023

Summary

  1. Gitlab plugin adopts ds_helpers
  2. Simplify blueprint_v200.go logic by adopting the ds_helpers

Does this close any open issues?

Part of #5519
Closes #6168

@klesh klesh force-pushed the kw-5519-gitlab-adopts-dshelper branch from d6a93e3 to 5cd5a48 Compare October 7, 2023 10:32
d4x1
d4x1 previously approved these changes Oct 8, 2023
Copy link
Copy Markdown
Contributor

@d4x1 d4x1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread backend/helpers/srvhelper/scope_service_helper.go
@abeizn abeizn merged commit eb93914 into apache:main Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Backend] Cannot start the backend service

3 participants