Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: gitlab adopts ds_helper #6173

Merged
merged 10 commits into from
Oct 8, 2023
Merged

refactor: gitlab adopts ds_helper #6173

merged 10 commits into from
Oct 8, 2023

Conversation

klesh
Copy link
Contributor

@klesh klesh commented Sep 28, 2023 •
edited
Loading

Summary

  1. Gitlab plugin adopts ds_helpers
  2. Simplify blueprint_v200.go logic by adopting the ds_helpers

Does this close any open issues?

Part of #5519
Closes #6168

@klesh klesh force-pushed the kw-5519-gitlab-adopts-dshelper branch from d6a93e3 to 5cd5a48 Compare October 7, 2023 10:32
d4x1
d4x1 previously approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@d4x1 d4x1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

backend/helpers/srvhelper/scope_service_helper.go Show resolved Hide resolved
@abeizn abeizn merged commit eb93914 into apache:main Oct 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeizn abeizn abeizn approved these changes

@d4x1 d4x1 d4x1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug][Backend] Cannot start the backend service
3 participants
@klesh @d4x1 @abeizn