Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-23736 Sql. Provide ability to catch start/finish events for query #4977

Merged
merged 18 commits into from
Jan 10, 2025

Conversation

xtern
Copy link
Contributor

@xtern xtern commented Dec 26, 2024

https://issues.apache.org/jira/browse/IGNITE-23736

Benchmark results (SelectBenchmark.sqlGet, fsync=off):

Note: the benchmark was executed with event logging disabled, i.e. the only difference is in event generation and calling the eventLog.log method.

branch clusterSize Mode Cnt Score Error Units
main 1 avgt 20 9.115 ± 0.286 us/op
ignite--23736 1 avgt 20 10.220 ± 0.234 us/op

UPDATE

Results after #5004
(the difference became within the margin of error (from launch to launch it can change in one direction or another))

branch clusterSize Mode Cnt Score Error Units
main 1 avgt 20 8.681 ± 0.278 us/op
ignite--23736 1 avgt 20 8.944 ± 0.254 us/op

With event logging enabled (logSink), but only event serialization, without writing to file, i.e.

logger.log(Level.DEBUG, serializer.serialize(event));

The result is:

branch clusterSize Mode Cnt Score Error Units
ignite--23736 1 avgt 20 12.693 ± 0.257 us/op

@xtern xtern marked this pull request as ready for review December 31, 2024 14:56
@xtern xtern merged commit a9d3974 into apache:main Jan 10, 2025
1 check passed
@xtern xtern deleted the ignite-23736 branch January 10, 2025 13:45
xtern added a commit that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants