Conversation
| Currently, iceberg-rust uses Docker to set up environment for integration tests. Native Docker has some limitations, please check (https://github.com/apache/iceberg-rust/pull/748). Please use Orbstack or Podman. | ||
|
|
||
| For MacOS users, you can install [OrbStack](https://orbstack.dev/) as a docker alternative. | ||
| For MacOS users, you can install [OrbStack as a docker alternative](docs/contributing/orbstack.md). |
There was a problem hiding this comment.
Adding guide about how to use a tool seems strange to me, unless we need project-specific settings. It should be enough to link to the tool's doc
There was a problem hiding this comment.
We have podman guide in repo. I think adding orbstack guide is helpful to new contributer as it's not trival to run tests like other rust projects, we should lower the threshold for new contributers as much as possible.
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @lewiszlw for this pr. I'm fine with adding some simple doc to help first time contributor.
|
|
||
| ``` | ||
| { | ||
| "registry-mirrors": ["https://registry.docker.ir", "https://docker.iranserver.com"] |
There was a problem hiding this comment.
nit: why are these registry mirrors part of the PR? The only reference i can find about these registry mirrors is here orbstack/orbstack#51 (comment)
It doesnt seem like these mirrors are commonly used
can we remove this recommendation or change it to a more commonly used mirror?
cc @liurenjie1024 @lewiszlw
There was a problem hiding this comment.
These registry mirrors are just example, copied from orbstack/orbstack#51 (comment) . I think we can change it like
{
"registry-mirrors": ["<mirror_addr>"]
}
There was a problem hiding this comment.
that sounds good to me, thanks!
Let's see if I can change it right here from github:
| "registry-mirrors": ["https://registry.docker.ir", "https://docker.iranserver.com"] | |
| "registry-mirrors": ["<mirror_addr>"] |
edit: guess not since its already merged. Would you like to make the change?
4 participants
No description provided.