Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update videos tags+thumbnails page 4 #9953

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

ckonehouse
Copy link

Change Logs

Added tags and thumbnails to the videos on page 4

Impact

Docs UI changes

Risk level (write none, low medium or high below)

None

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@bhasudha bhasudha added the docs label Oct 31, 2023
@bhasudha
Copy link
Contributor

@ckonehouse Please change the PR to merge into asf-site branch of Hudi not the master. Then you wont see 5K plus files changed in the PR.

@ckonehouse ckonehouse changed the base branch from master to asf-site October 31, 2023 16:35
@ckonehouse
Copy link
Author

@bhasudha Edited the PR to merge into the correct branch now

Copy link
Contributor

@bhasudha bhasudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few comments.

Copy link
Contributor

@bhasudha bhasudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhasudha bhasudha force-pushed the update-docs-tags+thumbnails-ck branch from ac6758d to 93584d1 Compare November 7, 2023 03:00
@bhasudha bhasudha merged commit 7dbacf2 into apache:asf-site Nov 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants