-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[HUDI-9421] Update restore/rollback/indexing planning and instant generation #13368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
} | ||
try { | ||
rollbackInstantTime = suppliedRollbackInstantTime.orElseGet(() -> createNewInstantTime(false)); | ||
if (commitInstantOpt.isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can move it to 1144 to avoid unnecessary lock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existing tests should cover this. We need some functional tests that test some of these concurrently and ensure the requested instants meet the guarantees.. Can we file a separate JIRA for "improve concurrency FTs" and we can come back to it after code freeze.
@vinothchandar Created this JIRA: https://issues.apache.org/jira/browse/HUDI-9478 |
@the-other-tim-brown Can you fix the title with correct JIRA ID, 941 seems not right. |
Fixed, it is HUDI-9421 |
Change Logs
Impact
Risk level (write none, low medium or high below)
Low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist