[HUDI-8776] Add schema evolution configs to SparkBroadcastManager #12510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linliu-code
force-pushed
the
ENG-18710-1
branch
from
afbf531 to
944a155
Compare
github-actions
bot
added
size:L
linliu-code
force-pushed
the
ENG-18710-1
branch
from
944a155 to
e14e51a
Compare
github-actions
bot
added
size:M
danny0405
reviewed
Dec 19, 2024
| Map<String, String> configs = new HashMap<>(); | ||
| if (internalSchemaOpt.isPresent()) { | ||
| List<String> instantFiles = timeline.getInstants().stream().map(fileNameGenerator::getFileName).collect(Collectors.toList()); | ||
| configs.put(SparkInternalSchemaConverter.HOODIE_VALID_COMMITS_LIST, String.join(",", instantFiles)); |
There was a problem hiding this comment.
Not sure why instant file name is needed, should we just use the instant timestamp string instead?
There was a problem hiding this comment.
@jonvex should be able to answer since Jon added this for fg reader.
There was a problem hiding this comment.
I'm sure I just copied this method
jonvex
approved these changes
Dec 19, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Add specific configs for schema evolution.
Impact
Support schema evolution better.
Risk level (write none, low medium or high below)
Low.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist