-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Refine quickstart docs further for 1.0 #12420
[DOCS] Refine quickstart docs further for 1.0 #12420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, can you please confirm if we can trim down some extra configs (which are not needed due to changed defaults) and how we use record mergers and not payloads.
MERGE INTO hudi_table AS target | ||
USING fare_adjustment AS source | ||
ON target.uuid = source.uuid | ||
WHEN MATCHED THEN UPDATE SET fare = source.fare |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, what exactly is the modification from example above. the previous one does not use UPDATE SET *
website/docs/sql_ddl.md
Outdated
primaryKey = 'id', | ||
precombineField = 'ts', | ||
recordMergeMode = 'CUSTOM', | ||
'hoodie.datasource.write.payload.class' = 'org.apache.hudi.common.model.PartialUpdateAvroPayload' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to show merger... not a payload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok i will update with the merger example.
Addressed both. Removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make another pass
Change Logs
Adds more quickstart docs around indexing, partial updates and merge mode.
Further refines the indexing docs, adds limitations and index acceleration related information.
Impact
Refines quickstart docs
Risk level (write none, low medium or high below)
low
Documentation Update
NA
Contributor's checklist