Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Only getCompletionTime for completedInstants #12359

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

yuzhaojing
Copy link
Contributor

@yuzhaojing yuzhaojing commented Nov 28, 2024

Change Logs

  • When lastMaxCompletionTime is present, we should only use completed instants to compare.

Impact

  • Only get completion time in complete timeline

Risk level (write none, low medium or high below)

None

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Nov 28, 2024
@TheR1sing3un
Copy link
Member

Hi, could u describe what happens before and after the fix if there is an unfinished instant in this scenario? NPE exception?

@yuzhaojing
Copy link
Contributor Author

Hi, could u describe what happens before and after the fix if there is an unfinished instant in this scenario? NPE exception?

Yes, a null pointer exception will be thrown here.
image

@yuzhaojing yuzhaojing force-pushed the fix_get_completion_time branch 2 times, most recently from 5f04b01 to b088111 Compare November 28, 2024 09:58
@yuzhaojing yuzhaojing requested a review from danny0405 December 4, 2024 04:24
@yuzhaojing
Copy link
Contributor Author

@hudi-bot run azure

@yuzhaojing
Copy link
Contributor Author

@danny0405 Can you take a look.

Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the test failure:

TestTimelineUtils.testGetCommitsTimelineAfter:325->verifyTimeline:

@yuzhaojing yuzhaojing force-pushed the fix_get_completion_time branch from b088111 to 55e47f5 Compare December 9, 2024 09:44
@hudi-bot
Copy link

hudi-bot commented Dec 9, 2024

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yuzhaojing
Copy link
Contributor Author

Can you fix the test failure:

TestTimelineUtils.testGetCommitsTimelineAfter:325->verifyTimeline:

All test succeed.

@danny0405 danny0405 merged commit 65e7edb into apache:master Dec 10, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS PR with lines of changes in <= 10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants