Skip to content

HIVE-29336: Upgrade compiler and javadoc plugins #6210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2025
+31 −35
Merged

HIVE-29336: Upgrade compiler and javadoc plugins #6210

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b33690e
HIVE-29336: Upgrade compiler and javadoc plugins
deniskuzZ Nov 22, 2025
366261c
changed default output directory
deniskuzZ Nov 23, 2025
ddd8034
upgrade root pom version
deniskuzZ Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions common/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,18 +414,6 @@
</testResource>
</testResources>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<compilerArgs>
<arg>--add-opens</arg>
Copy link
Member Author

@deniskuzZ deniskuzZ Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshat0395, why was it needed in the first place?

<arg>org.apache.hadoop/org.apache.hadoop.fs=ALL-UNNAMED</arg>
<arg>--add-opens</arg>
<arg>java.base/java.net=ALL-UNNAMED</arg>
</compilerArgs>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
Expand Down
10 changes: 8 additions & 2 deletions iceberg/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@
<artifactId>mockito-inline</artifactId>
<version>${iceberg.mockito-core.version}</version>
</dependency>
<dependency>
Copy link
Member Author

@deniskuzZ deniskuzZ Nov 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes sub-module compilation, until now compilation was failing within iceberg module

<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_annotations</artifactId>
<version>${google.errorprone.version}</version>
<scope>provided</scope>
</dependency>
</dependencies>
<dependencyManagement>
<dependencies>
Expand Down Expand Up @@ -324,11 +330,11 @@
<artifactId>error_prone_core</artifactId>
<version>${google.errorprone.version}</version>
</path>
<dependency>
<path>
<groupId>org.immutables</groupId>
<artifactId>value</artifactId>
<version>${immutables.value.version}</version>
</dependency>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
Expand Down
8 changes: 1 addition & 7 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>23</version>
<version>35</version>
</parent>
<groupId>org.apache.hive</groupId>
<artifactId>hive</artifactId>
Expand Down Expand Up @@ -1605,15 +1605,9 @@
<artifactId>exec-maven-plugin</artifactId>
<version>${maven.exec.plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.14.0</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.11.2</version>
<configuration>
<source>${maven.compiler.source}</source>
<outputDirectory>${project.build.directory}/site</outputDirectory>
Expand Down
10 changes: 0 additions & 10 deletions standalone-metastore/metastore-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,16 +609,6 @@
<artifactId>exec-maven-plugin</artifactId>
<version>${maven.exec.plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<compilerArgs>
<arg>--add-exports</arg>
Copy link
Member Author

@deniskuzZ deniskuzZ Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshat0395, same here

<arg>jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED</arg>
</compilerArgs>
</configuration>
</plugin>
</plugins>
</pluginManagement>
<plugins>
Expand Down
8 changes: 1 addition & 7 deletions standalone-metastore/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>23</version>
<version>35</version>
</parent>
<groupId>org.apache.hive</groupId>
<artifactId>hive-standalone-metastore</artifactId>
Expand Down Expand Up @@ -665,15 +665,9 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.14.0</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.11.2</version>
<configuration>
<source>${maven.compiler.source}</source>
<outputDirectory>${project.build.directory}/site</outputDirectory>
Expand Down
8 changes: 1 addition & 7 deletions storage-api/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>23</version>
<version>35</version>
</parent>
<groupId>org.apache.hive</groupId>
<artifactId>hive-storage-api</artifactId>
Expand Down Expand Up @@ -205,15 +205,9 @@
<artifactId>maven-surefire-plugin</artifactId>
<version>${maven.surefire.plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.14.0</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.11.2</version>
<configuration>
<source>${maven.compiler.source}</source>
<outputDirectory>${project.build.directory}/site</outputDirectory>
Expand Down