HIVE-29275: Stats autogather calculates the min statistic incorrectly #6194
+168
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...st/java/org/apache/hadoop/hive/metastore/columnstats/merge/DecimalColumnStatsMergerTest.java
Outdated
Show resolved
Hide resolved
thomasrebele
commented
Nov 18, 2025
...c/main/java/org/apache/hadoop/hive/metastore/columnstats/merge/DecimalColumnStatsMerger.java
Outdated
Show resolved
Hide resolved
...st/java/org/apache/hadoop/hive/metastore/columnstats/merge/DecimalColumnStatsMergerTest.java
Outdated
Show resolved
Hide resolved
...st/java/org/apache/hadoop/hive/metastore/columnstats/merge/DecimalColumnStatsMergerTest.java
Show resolved
Hide resolved
InvisibleProgrammer
approved these changes
Nov 18, 2025
Contributor
InvisibleProgrammer
left a comment
InvisibleProgrammer
left a comment
There was a problem hiding this comment.
I just had minor questions. On overall, it LGTM.
asf-ci-hive
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
kasakrisz
reviewed
Nov 19, 2025
...st/java/org/apache/hadoop/hive/metastore/columnstats/merge/DecimalColumnStatsMergerTest.java
Outdated
Show resolved
Hide resolved
kasakrisz
reviewed
Nov 19, 2025
...st/java/org/apache/hadoop/hive/metastore/columnstats/merge/DecimalColumnStatsMergerTest.java
Outdated
Show resolved
Hide resolved
kasakrisz
reviewed
Nov 20, 2025
...st/java/org/apache/hadoop/hive/metastore/columnstats/merge/DecimalColumnStatsMergerTest.java
Show resolved
Hide resolved
|
kasakrisz
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As described in HIVE-29275, the compareTo method of Decimal leads to wrong result. This PR proposes to use HiveDecimal#compareTo instead.
Why are the changes needed?
Fixes the stats processed by DecimalColumnStatsMerger.
Does this PR introduce any user-facing change?
Yes, the statistics might change.
How was this patch tested?
Unit tests, qfile tests.