HIVE-28996 Fix invalid string formatting to prevent NumberFormatExcep… #5849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniskuzZ
reviewed
Jun 6, 2025
There was a problem hiding this comment.
change looks good.
@shubhluck, would you mind adding a unit test for this?
|
@deniskuzZ Thanks for the review! I’ve added the requested unit test. Could you also add me to the committer list when convenient? |
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
deniskuzZ
reviewed
Jun 7, 2025
| long maxWriteIdOnFilesystem = 2L; // From source table insertions (2 operations) | ||
| long maxAllocatedWriteId = 1L; // From target table insertion (1 operation) | ||
|
|
||
| String expectedMessage = MessageFormat.format( |
There was a problem hiding this comment.
Please don't use the MessageFormat in the expectation, just hardcode and update the text
String expectedMessage = "The highest writeId [2] in the table 'acidtblpartmsck' is greater than the maximum writeId allocated in the metastore [1]"
Assert.assertTrue(e.getCause() instanceof MetaException);
Assert.assertEquals(expectedMessage, e.getCause().getMessage());
deniskuzZ
reviewed
Jun 7, 2025
| @@ -399,7 +399,7 @@ private void validateAndAddMaxTxnIdAndWriteId(long maxWriteIdOnFilesystem, long | |||
| long maxAllocatedWriteId = getMsc().getMaxAllocatedWriteId(dbName, tableName); | |||
| if (maxAllocatedWriteId > 0 && maxWriteIdOnFilesystem > maxAllocatedWriteId) { | |||
| throw new MetaException(MessageFormat | |||
| .format("The maximum writeId {} in table {} is greater than the maximum allocated in the metastore {}", | |||
| .format("The maximum writeId {0} in table {1} is greater than the maximum allocated in the metastore {2}", | |||
There was a problem hiding this comment.
The highest writeId [{0}] in the table '{1}' is greater than the maximum writeId allocated in the metastore [{2}]
|
@deniskuzZ thank you again for reviewing the PR, updated with suggested changes |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion
What changes were proposed in this pull request?
Fix invalid string formatting to prevent NumberFormatException
https://issues.apache.org/jira/browse/HIVE-28996
Why are the changes needed?
Fix invalid string formatting for MessageFormat class
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
NA