-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-28967: Support multiple partitions in RELOAD event #5832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
...ne-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
Show resolved
Hide resolved
@@ -40,7 +40,7 @@ protected ReloadMessage() { | |||
* | |||
* @return The Json format of Partition object if the table is partitioned else return null. | |||
*/ | |||
public abstract Partition getPtnObj() throws Exception; | |||
public abstract Iterable<Partition> getPartitionObjs() throws Exception; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might introduce the backward problem for this API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, clients consuming this event will have to update their code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.apache.org/jira/browse/IMPALA-14089 - Impala's grammar is changed to take in multiple partitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per my understanding, this reload event is only for Impala, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes correct
408cdd8
to
d90af91
Compare
|
What changes were proposed in this pull request?
To support multiple partitions in the Reload event
Why are the changes needed?
Clients like Impala can use this fire multiple partitions in a single RELOAD event
Does this PR introduce any user-facing change?
No
How was this patch tested?
Local