HIVE-28956 : Use msdb.alterPartitions() API and implement batching for alter table add column cascade command #5814
+33
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikramahuja1001
force-pushed
the
DirectSqlAddColumn
branch
from
eb1c3b1 to
db2dd7b
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
vikramahuja1001
force-pushed
the
DirectSqlAddColumn
branch
from
db2dd7b to
c754743
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
deniskuzZ
reviewed
May 16, 2025
...astore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
deniskuzZ
reviewed
May 19, 2025
...astore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
Outdated
Show resolved
Hide resolved
vikramahuja1001
force-pushed
the
DirectSqlAddColumn
branch
from
926a4c7 to
2a5cc01
Compare
vikramahuja1001
changed the title
|
|
@deniskuzZ , i have made the necessary changes. Could you please check the PR once again? |
deniskuzZ
reviewed
Jun 9, 2025
| msdb.alterPartition( | ||
| catName, dbname, name, part.getValues(), part, writeIdList); | ||
| } else { | ||
| String catalogName = catName; |
There was a problem hiding this comment.
@vikramahuja1001, why do we need new local vars? otherwise looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently Alter table add column cascade uses msdb.alterPartition API. This API only JDO based implementation. Instead of this use msdb.alterPartitions which supports both DirectSql and JDO Implementation and use batching as well.
Why are the changes needed?
DirectSql bein more optimized than JDO can improve performance for tables with very high number of partitions and very high number of columns.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested this on a 3 node cluster on a table with 5000+ partitions and 900+ columns.