HIVE-28505: OTEL: Implement OTEL Exporter to expose query details from HiveServer2. #5439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <groupId>io.opentelemetry</groupId> | ||
| <artifactId>opentelemetry-sdk-extension-autoconfigure</artifactId> | ||
| <version>${otel.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
Please add io.opentelemetry:opentelemetry-exporter-otlp as a dependency here as well.
| } else { | ||
| Span span = tracer.spanBuilder("LiveQuery" + lQuery.getQueryDisplay().getQueryId()) | ||
| .setAllAttributes(getAttributes(lQuery)).setStartTimestamp(lQuery.getBeginTime(), TimeUnit.MILLISECONDS) | ||
| .startSpan(); |
There was a problem hiding this comment.
We should be starting span and then setting the attributes.
Something like:
Span span = tracer.spanBuilder("LiveQuery" + lQuery.getQueryDisplay().getQueryId()).startSpan();
span.setAllAttributes(getAttributes(lQuery)).setStartTimestamp(lQuery.getBeginTime(), TimeUnit.MILLISECONDS);
Current approach is causing NULL pointer exception intermittently and interrupts the thread.
There was a problem hiding this comment.
Changed, let me know if it looks good, timestamp needs to be set before only, there is no method in Span it is there in builder only
There was a problem hiding this comment.
I'll test and let you know if it works fine.
ayushtkn
force-pushed
the
HIVE-28505
branch
2 times, most recently
from
ca3d9f8 to
342b7e6
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
ayushtkn
force-pushed
the
HIVE-28505
branch
from
342b7e6 to
4821a0c
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement OTEL Exporter to expose basic query details from HiveServer2
Why are the changes needed?
Better Usability & introduce various OTEL Clients to fetch query data
Does this PR introduce any user-facing change?
OTEL Clients can be configured to fetch data from HS2
Is the change a dependency upgrade?
No
How was this patch tested?
Mannual/Pending