HIVE-28502: Refactor method names that start with capital letters in … #5434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Need to rebase to fix the conflicts. BTW, I think if we can do checkstyle in the ci pipeline, then we will avoid lots of similar code style issue. |
…PasswdAuthenticationProvider class
difin
force-pushed
the
camelCase-Authenticate-mathod
branch
from
937516c to
f88dd25
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…PasswdAuthenticationProvider class
What changes were proposed in this pull request?
Rename PasswdAuthenticationProvider's 'Authenticate' method to 'authenticate' according to Java naming convention.
Why are the changes needed?
To fix a method name that is wrong according to Java naming conventions.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Existing unit tests and query tests.