Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-26227: Add support of catalog related statements for Hive ql #3288

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

wecharyu
Copy link
Contributor

What changes were proposed in this pull request?

Implement the ddl statements related to catalog, the statements can refer to HIVE-26227.

Why are the changes needed?

To support basic ddl operation for catalog through Hive ql.

Does this PR introduce any user-facing change?

Yes, we should add these new statements to DDL Document.

How was this patch tested?

Add a qtest catalog.q, can be test by command:

mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=catalog.q

@wecharyu
Copy link
Contributor Author

@pvary @deniskuzZ: Could you also review this PR?

@boneanxs
Copy link

A very great work! it's much easier for us to manage catalogs with DDL.

,catalog.return_ratio
,catalog.return_rank
,catalog.currency_rank
,`catalog`.item
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a backward incompatible change. Could we make the catalog a non-reserved keyword?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, done

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the [email protected] list if the patch is in need of reviews.

@deniskuzZ
Copy link
Member

re-triggered the build

Copy link
Contributor

@zhangbutao zhangbutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Waiting other folks to take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants