-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-26227: Add support of catalog related statements for Hive ql #3288
base: master
Are you sure you want to change the base?
Conversation
@pvary @deniskuzZ: Could you also review this PR? |
A very great work! it's much easier for us to manage catalogs with DDL. |
,catalog.return_ratio | ||
,catalog.return_rank | ||
,catalog.currency_rank | ||
,`catalog`.item |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a backward incompatible change. Could we make the catalog
a non-reserved keyword?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense, done
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
re-triggered the build |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
Waiting other folks to take another look.
What changes were proposed in this pull request?
Implement the ddl statements related to catalog, the statements can refer to HIVE-26227.
Why are the changes needed?
To support basic ddl operation for catalog through Hive ql.
Does this PR introduce any user-facing change?
Yes, we should add these new statements to DDL Document.
How was this patch tested?
Add a qtest
catalog.q
, can be test by command:mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=catalog.q