[feature] Add Korean i18n#4197
Open
moduvoice wants to merge 1 commit into
Open
Conversation
Add ko-KR.json (1241 keys) mirroring web-app/src/assets/i18n/en-US.json and register ko-KR in I18NService (Angular/ng-zorro-antd/@delon/date-fns locale data) and the setting-drawer i18n directive, so Korean is a fully selectable application UI language alongside en-US/zh-CN/zh-TW/ja-JP/pt-BR. Also add a Korean locale to the Docusaurus marketing/docs site (home/i18n/ko), mirroring the existing home/i18n/en structure (code.json, navbar.json, footer.json, docs sidebar labels, blog options) and register 'ko' in home/docusaurus.config.js locales. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Korean (ko) translation PR body template
Motivation
This adds Korean (
ko) translation support — to help Korean-speaking users use thisopen-source project more comfortably in their own language.
한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 하였습니다.
Changes
Adds Korean translation across both the web-app UI and the docs site (1509 keys total):
web-app/src/assets/i18n/ko-KR.json— full Korean translation of the web-app UI (1241/1241 keys, full parity withen-US.json)web-app/src/app/core/i18n/i18n.service.ts— registersko-KRas a selectable language (Angular/date-fns/ng-zorro-antd/@delon locale wiring), following the same pattern used forja-JPweb-app/src/app/layout/basic/directives/setting-drawer-i18n.directive.ts— addsko-KRto the languages list used by the settings-drawer live-translation directiveweb-app/src/app/layout/basic/directives/setting-drawer-i18n.directive.spec.ts— updates the existing spec to mock/assert the newko-KRHTTP request alongside the existing localeshome/i18n/ko/**— Korean translation for the Docusaurus docs site chrome (code.json, navbar, footer, docs sidebar labels forcurrentandversion-1.8.0, blog options) — 268/268 keys, full parity with theensourcehome/docusaurus.config.js— registerskoin the Docusaurusi18n.localeslistBrand/product names (HertzBeat, GitHub, ASF), API/field identifiers, and technical terms (e.g. NGQL) were intentionally left untranslated, consistent with the existing
ja-JP.json/pt-BR.jsonpattern.Testing
ko-KR.jsonvsen-US.json→ 1241/1241 keys match, no missing/extra/empty values.kofiles against theirencounterparts → 268/268 keys match.setting-drawer-i18n.directive.spec.ts— the updated spec correctly mocks the new./assets/i18n/ko-KR.jsonHTTP request in the same position as the other locales and itshttpMock.verify()expectations are consistent with the directive change.