[fix] Fix notice rule label matching against grouped alerts#4191
Merged
Conversation
Aias00
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
close #3852
The issue is that the rule label routing matches
GroupAlert.commonLabels, which is the intersection of all alert labels in that group. Since there are only grouped rules and the alert labels within the group do not match, labels are excluded from this intersection. As a result, the notification policy for that label will never match, and only the “Forward All” rule will be triggered.This PR changes the matching logic to check the alerts at the bottom of the group: the rule is matched when any alert in the group contains all the tags specified in the rule.
Checklist
Add or update API