Skip to content

[Fix]: fix TAG type mismatch by introducing schema version for TDengine#3963

Merged
Duansg merged 1 commit into
apache:masterfrom
Saramanda9988:issue-3961
Jan 13, 2026
Merged

[Fix]: fix TAG type mismatch by introducing schema version for TDengine#3963
Duansg merged 1 commit into
apache:masterfrom
Saramanda9988:issue-3961

Conversation

@Saramanda9988

Copy link
Copy Markdown
Contributor

What's changed?

Please refer to #3961

This PR resolves the issue where the monitor TAG was incorrectly defined as BIGINT in v1.8.0, causing insertion failures for string-based instance

  1. appended a _v2 suffix to both Super Table and Sub-table names (e.g., ..._super_v2). This bypasses TDengine's limitation where TAG column types cannot be modified after table creation.
  2. Updated monitor TAG type to NCHAR(128) in the new v2 schema.
image image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@Duansg Duansg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't Prometheus's task need to be handled?

@Saramanda9988

Saramanda9988 commented Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

Hi @Duansg ,

Are you referring to the table name mismatch issue caused by users modifying the monitor name of Prometheus tasks?
If so, I find that this problem also exists in IotDB, QuestDB, and InfluxDB, but not in GreptimeDB (which only uses metrics) and VictoriaMetrics (which uses labels)

image

Perhaps we should address these related issues separately through a dedicated PR? This PR can focus on fixing TDengine's TAG issue.

Please let me know if I understood your concern correctly or you'd like me to fix TDengine's related issue just in this issue.

@Duansg

Duansg commented Jan 13, 2026

Copy link
Copy Markdown
Member

Are you referring to the table name mismatch issue caused by users modifying the monitor name of Prometheus tasks?

That's correct, this is a historical issue, not caused by the instance reconstruction. I've reviewed the relevant logic and found it's not straightforward. Even a simple modification to ensure compatibility would require extensive regression testing on other dependent features. To ensure the issue remains traceable, I'll create a new PR to address this later.

@Saramanda9988

Saramanda9988 commented Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

Are you referring to the table name mismatch issue caused by users modifying the monitor name of Prometheus tasks?

That's correct, this is a historical issue, not caused by the instance reconstruction. I've reviewed the relevant logic and found it's not straightforward. Even a simple modification to ensure compatibility would require extensive regression testing on other dependent features. To ensure the issue remains traceable, I'll create a new PR to address this later.

OK,thanks
If needed, I’m happy to help with some testing for that.

@Duansg

Duansg commented Jan 13, 2026

Copy link
Copy Markdown
Member

Are you referring to the table name mismatch issue caused by users modifying the monitor name of Prometheus tasks?

That's correct, this is a historical issue, not caused by the instance reconstruction. I've reviewed the relevant logic and found it's not straightforward. Even a simple modification to ensure compatibility would require extensive regression testing on other dependent features. To ensure the issue remains traceable, I'll create a new PR to address this later.

OK,thanks If needed, I’m happy to help with some testing for that.

👍🏿 ok, i suggest you reproduce the issue and file a ticket so we can track it :)

@Duansg Duansg merged commit dc96f17 into apache:master Jan 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants