-
Notifications
You must be signed in to change notification settings - Fork 241
Preserve input instance order in zone_based stoppable check #3029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LZD-PratyushBhatt
wants to merge
6
commits into
apache:master
Choose a base branch
from
LZD-PratyushBhatt:lzd_pratyush/preserve_order
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Preserve input instance order in zone_based stoppable check #3029
LZD-PratyushBhatt
wants to merge
6
commits into
apache:master
from
LZD-PratyushBhatt:lzd_pratyush/preserve_order
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junkaixue
reviewed
Apr 30, 2025
...rc/main/java/org/apache/helix/rest/clusterMaintenanceService/StoppableInstancesSelector.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/helix/rest/clusterMaintenanceService/StoppableInstancesSelector.java
Outdated
Show resolved
Hide resolved
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java
Outdated
Show resolved
Hide resolved
f11bc8a to
888dbb0
Compare
|
Hi @junkaixue, |
.../main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java
Show resolved
Hide resolved
MarkGaox
reviewed
May 12, 2025
...rc/main/java/org/apache/helix/rest/clusterMaintenanceService/StoppableInstancesSelector.java
Show resolved
Hide resolved
.../main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java
Show resolved
Hide resolved
e7ec03b to
b91986d
Compare
b91986d to
791c08f
Compare
|
Triggered CI in my fork as well, a single test failure, but that seems unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
(#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
This PR fixes #3028 Preserve input instance order in zone_based stoppable checks.
Description
(Write a concise description including what, why, how)
Tests
(List the names of added unit/integration tests)
testMultipleReplicasInSameMZWithPreserveOrderis added.(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)