Skip to content

Make the keymeta table initialization happen in a predictable manner #7433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2025
Merged

Make the keymeta table initialization happen in a predictable manner #7433

merged 3 commits into from
Nov 5, 2025

Conversation

@haridsv
Copy link
Contributor

@haridsv haridsv commented Nov 3, 2025 •
edited
Loading

During the system boot up, we need to ensure that keymeta table regions are online before any of the encrypted stores are opened for assignment, if not we can have a race condition that can cause the assignments to fail. This change introduces a priority check for hbase:keymeta table on the lines of hbase:meta.

Addendum to PR #7421

@Apache-HBase
Copy link

Apache-HBase commented Nov 3, 2025

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 39s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 buf 0m 0s buf was not available.
+0 🆗 buf 0m 0s buf was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for branch
+1 💚 mvninstall 4m 22s HBASE-29368-key-management-feature passed
+1 💚 compile 5m 33s HBASE-29368-key-management-feature passed
+1 💚 checkstyle 1m 11s HBASE-29368-key-management-feature passed
+1 💚 spotbugs 5m 8s HBASE-29368-key-management-feature passed
-1 ❌ spotless 0m 53s branch has 22 errors when running spotless:check, run spotless:apply to fix.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 23s the patch passed
+1 💚 compile 5m 27s the patch passed
+1 💚 cc 5m 27s the patch passed
+1 💚 javac 5m 27s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 1s the patch passed
+1 💚 spotbugs 5m 42s the patch passed
+1 💚 hadoopcheck 18m 55s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 hbaseprotoc 1m 54s the patch passed
+1 💚 spotless 0m 56s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
68m 5s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7433
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname Linux 0493c21bcd35 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-29368-key-management-feature / 71e37da
Default Java Eclipse Adoptium-17.0.11+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/1/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-procedure hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 3, 2025

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 54s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for branch
+1 💚 mvninstall 4m 32s HBASE-29368-key-management-feature passed
+1 💚 compile 2m 13s HBASE-29368-key-management-feature passed
+1 💚 javadoc 1m 0s HBASE-29368-key-management-feature passed
+1 💚 shadedjars 7m 19s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 27s the patch passed
+1 💚 compile 2m 11s the patch passed
+1 💚 javac 2m 11s the patch passed
+1 💚 javadoc 1m 4s the patch passed
+1 💚 shadedjars 7m 6s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 45s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 54s hbase-procedure in the patch passed.
-1 ❌ unit 238m 22s /patch-unit-hbase-server.txt hbase-server in the patch failed.
277m 53s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7433
Optional Tests javac javadoc unit compile shadedjars
uname Linux fefb50ccd632 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-29368-key-management-feature / 71e37da
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/1/testReport/
Max. process+thread count 4497 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-procedure hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 3, 2025

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 13s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 buf 0m 0s buf was not available.
+0 🆗 buf 0m 0s buf was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for branch
+1 💚 mvninstall 5m 15s HBASE-29368-key-management-feature passed
+1 💚 compile 9m 14s HBASE-29368-key-management-feature passed
+1 💚 checkstyle 2m 31s HBASE-29368-key-management-feature passed
+1 💚 spotbugs 11m 12s HBASE-29368-key-management-feature passed
-1 ❌ spotless 1m 21s branch has 22 errors when running spotless:check, run spotless:apply to fix.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 7m 4s the patch passed
+1 💚 compile 9m 20s the patch passed
+1 💚 cc 9m 20s the patch passed
+1 💚 javac 9m 20s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 2m 30s the patch passed
+1 💚 spotbugs 12m 1s the patch passed
+1 💚 hadoopcheck 18m 17s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 hbaseprotoc 3m 35s the patch passed
+1 💚 spotless 1m 22s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 1m 8s The patch does not generate ASF License warnings.
98m 12s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7433
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname Linux 79cd92708ba9 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-29368-key-management-feature / 6080077
Default Java Eclipse Adoptium-17.0.11+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/2/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count 71 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 4, 2025

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 33s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 3m 34s HBASE-29368-key-management-feature passed
+1 💚 compile 2m 33s HBASE-29368-key-management-feature passed
+1 💚 javadoc 1m 38s HBASE-29368-key-management-feature passed
+1 💚 shadedjars 6m 18s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 8s the patch passed
+1 💚 compile 2m 32s the patch passed
+1 💚 javac 2m 32s the patch passed
+1 💚 javadoc 1m 35s the patch passed
+1 💚 shadedjars 6m 11s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 33s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 37s hbase-client in the patch passed.
+1 💚 unit 1m 26s hbase-procedure in the patch passed.
+1 💚 unit 243m 31s hbase-server in the patch passed.
+1 💚 unit 7m 30s hbase-thrift in the patch passed.
288m 34s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7433
Optional Tests javac javadoc unit compile shadedjars
uname Linux 586d270e6e99 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-29368-key-management-feature / 6080077
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/2/testReport/
Max. process+thread count 3890 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani virajjasani merged commit c22e111 into apache:HBASE-29368-key-management-feature Nov 5, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@virajjasani virajjasani virajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@haridsv @Apache-HBase @virajjasani