You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Routers don't have support for listOpenFiles yet. Single destination paths are straightforward. Multi destination paths are joined; entries with inodeId > min(max(entry inodeIds)) are ignored to get a consistent prevId for the iterator.
The implementation is the same as the logic used for aligning results from multiple destinations in router getListing.
does the output gives path wrt router mount points or the actual paths in the namespace, like /mnt mounts ns1 /dir/subdir1
so a file /dir/subdir1/file1 should be shown as /mnt1/file1 when doing getOpenFiles via router
does the output gives path wrt router mount points or the actual paths in the namespace, like /mnt mounts ns1 /dir/subdir1 so a file /dir/subdir1/file1 should be shown as /mnt1/file1 when doing getOpenFiles via router
@ayushtkn Thanks for the review! I have updated the implementation to return the mount source path instead of the actual paths
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
(reopened due to ticket being auto closed)
Routers don't have support for listOpenFiles yet. Single destination paths are straightforward. Multi destination paths are joined; entries with inodeId > min(max(entry inodeIds)) are ignored to get a consistent prevId for the iterator.
The implementation is the same as the logic used for aligning results from multiple destinations in router getListing.
How was this patch tested?
UTs