Skip to content

[MINOR][CORE] Seal GlutenCost and drop unreachable case in LongCostModel #12586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuciferYang wants to merge 1 commit into from
Closed

[MINOR][CORE] Seal GlutenCost and drop unreachable case in LongCostModel #12586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion gluten-core/src/main/scala/org/apache/gluten/extension/columnar/cost/GlutenCost.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,6 @@
*/
package org.apache.gluten.extension.columnar.cost

trait GlutenCost
sealed trait GlutenCost

case class LongCost(value: Long) extends GlutenCost
19 changes: 0 additions & 19 deletions gluten-core/src/main/scala/org/apache/gluten/extension/columnar/cost/LongCost.scala
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion gluten-core/src/main/scala/org/apache/gluten/extension/columnar/cost/LongCostModel.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ abstract class LongCostModel extends GlutenCostModel {

override def costComparator(): Ordering[GlutenCost] = Ordering.Long.on {
case LongCost(value) => value
case _ => throw new IllegalStateException("Unexpected cost type")
}

override def makeInfCost(): GlutenCost = LongCost(infLongCost)
Expand Down
Loading