Skip to content

[VL] Disable useHashTableCache if the hash table is not pre-built during HashJoinNode creation #12487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JkSelf merged 3 commits into from
Jul 10, 2026
Merged

[VL] Disable useHashTableCache if the hash table is not pre-built during HashJoinNode creation #12487

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9263d72
fix
JkSelf Jul 10, 2026
70138b1
fix
JkSelf Jul 10, 2026
954ea96
fix
JkSelf Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions cpp/velox/substrait/SubstraitToVeloxPlan.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,21 @@ core::PlanNodePtr SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
} else if (
sJoin.has_advanced_extension() &&
SubstraitParser::configSetInOptimization(sJoin.advanced_extension(), "isBHJ=")) {
const std::string hashTableId = sJoin.hashtableid();
bool useHashTableCache = false;
if (!hashTableId.empty()) {
try {
const auto handle = getJoin(hashTableId);
Comment on lines +461 to +465
if (handle != 0) {
auto hashTableBuilder = ObjectStore::retrieve<gluten::HashTableBuilder>(handle);
useHashTableCache = (hashTableBuilder != nullptr);
Comment on lines +464 to +468
}
} catch (const std::exception& e) {
LOG(WARNING) << "Failed to retrieve pre-built HashTableBuilder for cache key: " << hashTableId
<< ", error: " << e.what() << ". Disable hash table cache and build a new table.";
}
}
Comment on lines +461 to +474

// Create HashJoinNode node
return std::make_shared<core::HashJoinNode>(
nextPlanNodeId(),
Expand All @@ -469,11 +484,11 @@ core::PlanNodePtr SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
leftNode,
rightNode,
getJoinOutputType(leftNode, rightNode, joinType),
true,
useHashTableCache,
false,
false,
nullptr,
sJoin.hashtableid());
useHashTableCache ? hashTableId : std::string());
} else {
// Create HashJoinNode node
return std::make_shared<core::HashJoinNode>(
Expand Down
Loading