[VL] Fix GlutenKeyGroupedPartitioningSuite in Spark 4.1#12482
Merged
Conversation
zml1206
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Gluten’s Spark 4.1 KeyGroupedPartitioning test suite to account for new upstream SPARK-54439 coverage by excluding Spark’s original SPARK-54439 tests under Velox settings and adding Gluten-specific replacements intended to validate the expected fallback behavior.
Changes:
- Added two new
testGlutencases inGlutenKeyGroupedPartitioningSuitefor SPARK-54439 join-key/partitioning-key size mismatch scenarios. - Updated Velox Spark 4.1 test settings to exclude Spark tests prefixed with
SPARK-54439.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gluten-ut/spark41/src/test/scala/org/apache/spark/sql/connector/GlutenKeyGroupedPartitioningSuite.scala | Adds Gluten-specific SPARK-54439 tests intended to validate fallback behavior for key-size mismatch cases. |
| gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Excludes Spark-side SPARK-54439 tests for Velox Spark 4.1 runs so Gluten-specific variants can be used instead. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2055
to
+2057
| val shuffles = collectShuffles(df.queryExecution.executedPlan) | ||
| assert(shuffles.size == 1, "only shuffle one side not report partitioning") | ||
|
|
Comment on lines
+2082
to
+2084
| val shuffles = collectShuffles(df.queryExecution.executedPlan) | ||
| assert(shuffles.size == 1, "only shuffle one side not report partitioning") | ||
|
|
Member
|
related: #11400 |
zhouyuan
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
GlutenKeyGroupedPartitioningSuitefor Spark 4.1 to handle the new SPARK-54439 test coverage.Spark 4.1 added tests for KeyGroupedPartitioning cases where the reported partitioning key size does not match the join key size. Since Gluten does not currently support these cases with native columnar shuffle, this PR excludes the original Spark-side SPARK-54439 tests from the Velox settings and adds Gluten-aware versions that validate the expected fallback behavior.