Skip to content

[VL] Refine the symbol exporting and reduce binary size #12404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zhouyuan wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[VL] Refine the symbol exporting and reduce binary size #12404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cpp/core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,9 @@ add_dependencies(gluten jni_proto)
if(NOT CMAKE_SYSTEM_NAME MATCHES "Darwin")
target_link_options(
gluten PRIVATE -Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)
# Strip the symbol table in Release builds to reduce binary size.
target_link_options(gluten PRIVATE
$<$<NOT:$<CONFIG:Debug>>:-Wl,-s>)
endif()

if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9.0)
Expand Down
7 changes: 5 additions & 2 deletions cpp/velox/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,10 +258,13 @@ if(GLUTEN_VELOX_ENABLE_PARQUET)
message(STATUS "Propagating VELOX_ENABLE_PARQUET to Gluten Velox backend")
endif()

if(ENABLE_GLUTEN_VCPKG AND NOT CMAKE_SYSTEM_NAME MATCHES "Darwin")
# Hide some symbols to avoid conflict.
if(NOT CMAKE_SYSTEM_NAME MATCHES "Darwin")
# Hide symbols not needed by JNI callers.
target_link_options(
velox PRIVATE -Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)
# Strip the symbol table in Release builds to reduce binary size.
target_link_options(velox PRIVATE
$<$<NOT:$<CONFIG:Debug>>:-Wl,-s>)
endif()

find_protobuf()
Expand Down
Loading