Skip to content
Draft
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,41 @@ class VeloxIteratorApi extends IteratorApi with Logging {
// Only serialize plan once, save lots time when plan is complex.
val planByteArray = wsCtx.root.toProtobuf.toByteArray

// Capture fs.azure.* / fs.s3a.* / fs.gs.* keys from the driver-side
// Hadoop configuration NOW, while we are still on the driver, and embed
// them in every GlutenPartition. These keys are set by the user via
// spark.conf.set("fs.azure.account.auth.type", ...) or

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. The comment block at lines 128–144 still advertises spark.conf.set(...), DataFrameReader.option(...), and sessionState.newHadoopConf() as user surfaces — none of those reach the new code path, which only reads SparkContext.getOrCreate().hadoopConfiguration. The actual recipes that work are submit‑time --conf spark.hadoop.fs.*=… (which Spark copies into SparkContext.hadoopConfiguration at boot) or runtime sparkContext.hadoopConfiguration.set("fs.*", ...). spark.conf.set("spark.hadoop.fs.*", ...) set at runtime writes to SQLConf only and is invisible to the new code.
  2. The paragraph starting "Capture fs.azure.* …" is duplicated at line 137 — looks like a merge artefact. Please collapse into one paragraph and rewrite the recipe.

// sparkContext.hadoopConfiguration.set(...)
Comment on lines +129 to +132
// Spark's withSQLConfPropagated only forwards keys starting with "spark"
// as task-local-properties, so "fs.*" keys never reach the executor's
// SQLConf. Serialising them inside the partition is the only safe way
// to make them available to the native runtime on the executor.
// Capture fs.azure.* / fs.s3a.* / fs.gs.* keys while on the driver.
// SparkPlan.sqlContext is available on the driver -- using the first leaf
// gives us access to sessionState.newHadoopConf() which includes all keys
// set via spark.conf.set(), sparkContext.hadoopConfiguration, and
// DataFrameReader.option(). These are NOT propagated to executors by
// Spark's withSQLConfPropagated (it only forwards keys starting with
// "spark"), so embedding them in the serialised GlutenPartition is the
// only reliable transport mechanism.
val fsPrefixes = Seq("fs.azure.", "fs.s3a.", "fs.gs.")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We can define this part as a constant and allow users to extend it (via configuration or by adding a constant prefix), which would make the user experience more friendly.

val hadoopConf = leaves.headOption
.map(_ => org.apache.spark.sql.SparkSession.active.sessionState.newHadoopConf())
.getOrElse(org.apache.spark.SparkContext.getOrCreate().hadoopConfiguration)
Comment thread
zhouyuan marked this conversation as resolved.
Outdated
Comment thread
zhouyuan marked this conversation as resolved.
Outdated
Comment thread
zhouyuan marked this conversation as resolved.
Outdated
val fsConf = {
hadoopConf.iterator().asScala

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR — this is a problem we've hit before. Internally we addressed it by injecting a known Hadoop key list at a specific injection point.
The hadoopConf.iterator() would return the full configuration set, which has a noticeable performance cost. Besides, some of the configu entries are also unresolved — values like .key=${...} aren't decoded, so the velox backend fails to parse them. I haven't come across a cleaner solution yet.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Hadoop Configuration has getPropsWithPrefix in the Hadoop versions Gluten supports, so I’ll replace the full iterator() scan with prefix lookups for fs.azure., fs.s3a., and fs.gs.. This keeps the same propagation behavior but avoids iterating the entire configuration set.

.filter(e => fsPrefixes.exists(e.getKey.startsWith))
.map(e => e.getKey -> e.getValue)
.toMap
}

splitInfos.zipWithIndex.map {
case (splitInfos, index) =>
GlutenPartition(
index,
planByteArray,
splitInfos.toArray
splitInfos.toArray,
fsConf = fsConf

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assigning fsConf = fsConf puts an independent serialised copy of the map on every GlutenPartition — reference sharing is driver‑side only, the wire cost scales with partition count.

)
}
}
Expand Down Expand Up @@ -199,7 +228,16 @@ class VeloxIteratorApi extends IteratorApi with Logging {
iter => new ColumnarBatchInIterator(BackendsApiManager.getBackendName, iter.asJava)
}

val extraConf = Map(GlutenConfig.COLUMNAR_CUDF_ENABLED.key -> enableCudf.toString).asJava
// Merge the fs.* keys captured on the driver (stored in GlutenPartition.fsConf)
// into the extraConf passed to NativePlanEvaluator / VeloxRuntime.
// Runtimes.contextInstance() will call GlutenConfig.getNativeSessionConf() which
// merges extraConf on top of SQLConf.get.getAllConfs. Because the executor-side
// SQLConf never receives "fs.*" keys (Spark only propagates "spark.*" keys via
// task local properties), this is the only path these credentials can take to
// reach the native session config and ultimately the Velox ABFS connector.
val partitionFsConf = inputPartition.asInstanceOf[GlutenPartition].fsConf
val extraConf = (partitionFsConf +

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CWE‑532: This line is where fsConf reaches extraConf and ultimately flows into the native session config printed by printConfig (cpp side). printConfig redacts on key match against spark.redaction.regex, default (?i)secret|password|token|access[.]?key. That default misses fs.azure.account.key.* (the Azure storage account key — the primary credential), fs.s3a.encryption.key and the deprecated alias fs.s3a.server-side-encryption.key, fs.gs.auth.service.account.private.key, and fs.gs.auth.service.account.json.keyfile. With spark.gluten.sql.debug=true these reach executor stdout in cleartext. The fix is on the C++ side: please hard‑redact the credential‑bearing prefixes inside printConfig in addition to applying the operator regex — minimum list: fs.azure.account.key., fs.azure.sas., fs.azure.account.oauth2., fs.s3a.access.key, fs.s3a.secret.key, fs.s3a.session.token, fs.s3a.encryption.key, fs.s3a.server-side-encryption.key, fs.gs.auth.service.account.private.key, fs.gs.auth.service.account.json.keyfile. Consider also extending Gluten's default spark.redaction.regex to cover them.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it seems pass these configurations as a parameter will introduce the credential leakage. Let me try to use the other more secure approach

(GlutenConfig.COLUMNAR_CUDF_ENABLED.key -> enableCudf.toString)).asJava
val transKernel = NativePlanEvaluator.create(BackendsApiManager.getBackendName, extraConf)
Comment on lines +237 to 240

Comment on lines +237 to 241

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed by adding a digest on the key/password

val splitInfoByteArray = inputPartition
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,146 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.gluten.backendsapi.velox

import org.apache.gluten.execution.{GlutenPartition, WholeStageTransformContext}
import org.apache.gluten.substrait.plan.PlanBuilder

import org.apache.spark.sql.test.SharedSparkSession

/**
* Tests that [[VeloxIteratorApi.genPartitions]] captures fs.azure.*, fs.s3a.*, and fs.gs.* keys
* from the driver-side Hadoop configuration and embeds them in [[GlutenPartition.fsConf]], so they
* are available on executors where Spark's SQLConf propagation does not reach "fs.*" keys.
*
* Keys must be set on `sparkContext.hadoopConfiguration` (the mutable base configuration) because
* `sessionState.newHadoopConf()` creates a fresh copy each time - mutations to its return value are
* discarded before the next call.
*/
class VeloxIteratorApiFsConfSuite extends SharedSparkSession {

private val api = new VeloxIteratorApi

/**
* Build a minimal WholeStageTransformContext backed by an empty Substrait plan. genPartitions
* only calls wsCtx.root.toProtobuf.toByteArray, so a plan with no relations is sufficient for the
* purpose of this test.
*/
private def emptyWsCtx: WholeStageTransformContext =
WholeStageTransformContext(PlanBuilder.empty())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emptyWsCtx only works because genPartitions happens to touch only wsCtx.root.toProtobuf.toByteArray, but WholeStageTransformContext has other fields — a future shape change silently breaks the helper. Either refactor genPartitions to take Array[Byte] directly (cleanest), or add a one‑line comment recording the implicit dependency. Non‑blocking.


/**
* Set Hadoop conf keys on the underlying mutable configuration and restore their previous values
* (or unset them) after the block. `sessionState.newHadoopConf()` copies from
* `sparkContext.hadoopConfiguration`, so this is the correct mutation point.
*/
private def withHadoopConf(pairs: (String, String)*)(body: => Unit): Unit = {
// scalastyle:off hadoopconfiguration
val hadoopConf = spark.sparkContext.hadoopConfiguration
// scalastyle:off hadoopconfiguration
Comment thread
zhouyuan marked this conversation as resolved.
Outdated
val prev: Seq[(String, Option[String])] = pairs.map {
case (k, _) => k -> Option(hadoopConf.get(k))
}
pairs.foreach { case (k, v) => hadoopConf.set(k, v) }
try body
finally prev.foreach {
case (k, Some(old)) => hadoopConf.set(k, old)
case (k, None) => hadoopConf.unset(k)
}
}

test("genPartitions embeds fs.azure.* keys from Hadoop conf into GlutenPartition.fsConf") {
withHadoopConf(
"fs.azure.account.auth.type.myaccount.dfs.core.windows.net" -> "OAuth",
"fs.azure.account.oauth.provider.type" -> "ClientCredentials"
) {
val partitions = api.genPartitions(emptyWsCtx, Seq(Seq.empty), Seq.empty)
Comment on lines +65 to +70
assert(partitions.size == 1)
val fsConf = partitions.head.asInstanceOf[GlutenPartition].fsConf
assert(
fsConf.contains("fs.azure.account.auth.type.myaccount.dfs.core.windows.net"),
s"Expected fs.azure key not found; got: ${fsConf.keys.mkString(", ")}")
assert(fsConf("fs.azure.account.auth.type.myaccount.dfs.core.windows.net") == "OAuth")
assert(
fsConf.contains("fs.azure.account.oauth.provider.type"),
s"Expected fs.azure key not found; got: ${fsConf.keys.mkString(", ")}")
assert(fsConf("fs.azure.account.oauth.provider.type") == "ClientCredentials")
}
}
Comment thread
zhouyuan marked this conversation as resolved.

test("genPartitions embeds fs.s3a.* keys from Hadoop conf into GlutenPartition.fsConf") {
withHadoopConf(
"fs.s3a.access.key" -> "AKIAIOSFODNN7EXAMPLE",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AKIAIOSFODNN7EXAMPLE is AWS's documentation example and matches the AKIA/ASIA pattern used by GitHub secret scanning, gitleaks, and most fork‑level scanners. Even as a test fixture, this routinely fails CI in downstream forks and surfaces as false‑positive credential alerts. Use clearly synthetic placeholders, e.g. "dummy-access-key" / "dummy-secret-value".

"fs.s3a.secret.key" -> "wJalrXUtnFEMI"
Comment thread
zhouyuan marked this conversation as resolved.
) {
Comment on lines +85 to +88
val partitions = api.genPartitions(emptyWsCtx, Seq(Seq.empty), Seq.empty)
assert(partitions.size == 1)
val fsConf = partitions.head.asInstanceOf[GlutenPartition].fsConf
assert(
fsConf.contains("fs.s3a.access.key"),
s"Expected fs.s3a.access.key not found; got: ${fsConf.keys.mkString(", ")}")
assert(fsConf("fs.s3a.access.key") == "AKIAIOSFODNN7EXAMPLE")
assert(fsConf.contains("fs.s3a.secret.key"))
assert(fsConf("fs.s3a.secret.key") == "wJalrXUtnFEMI")
}
}
Comment thread
zhouyuan marked this conversation as resolved.
Comment on lines +84 to +99

test("genPartitions embeds fs.gs.* keys from Hadoop conf into GlutenPartition.fsConf") {
withHadoopConf("fs.gs.auth.service.account.json.keyfile" -> "/tmp/sa.json") {
val partitions = api.genPartitions(emptyWsCtx, Seq(Seq.empty), Seq.empty)
assert(partitions.size == 1)
val fsConf = partitions.head.asInstanceOf[GlutenPartition].fsConf
assert(
fsConf.contains("fs.gs.auth.service.account.json.keyfile"),
s"Expected fs.gs key not found; got: ${fsConf.keys.mkString(", ")}")
assert(fsConf("fs.gs.auth.service.account.json.keyfile") == "/tmp/sa.json")
}
}
Comment thread
zhouyuan marked this conversation as resolved.

test("genPartitions does not include non-fs.* keys in GlutenPartition.fsConf") {
withHadoopConf(
"fs.s3a.access.key" -> "KEY",
"mapreduce.input.fileinputformat.split.maxsize" -> "128000000"
) {
val partitions = api.genPartitions(emptyWsCtx, Seq(Seq.empty), Seq.empty)
val fsConf = partitions.head.asInstanceOf[GlutenPartition].fsConf
assert(
!fsConf.contains("mapreduce.input.fileinputformat.split.maxsize"),
"Non-fs key must not appear in fsConf")
// fs.s3a.access.key must be captured
assert(
fsConf.contains("fs.s3a.access.key"),
s"Expected fs.s3a.access.key not found; got: ${fsConf.keys.mkString(", ")}")
}
}
Comment thread
zhouyuan marked this conversation as resolved.

test("genPartitions produces one partition per input split group") {
withHadoopConf("fs.s3a.endpoint" -> "s3.amazonaws.com") {
// Two split groups => two GlutenPartitions
val partitions =
api.genPartitions(emptyWsCtx, Seq(Seq.empty, Seq.empty), Seq.empty)
assert(partitions.size == 2)
partitions.foreach {
p =>
val fsConf = p.asInstanceOf[GlutenPartition].fsConf
assert(
fsConf.contains("fs.s3a.endpoint"),
s"Expected fs.s3a.endpoint not found; got: ${fsConf.keys.mkString(", ")}")
assert(fsConf("fs.s3a.endpoint") == "s3.amazonaws.com")
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,13 @@ case class GlutenPartition(
index: Int,
plan: Array[Byte],
splitInfos: Array[SplitInfo] = Array.empty[SplitInfo],
files: Array[String] =
Array.empty[String] // touched files, for implementing UDF input_file_name
files: Array[String] = Array.empty[String], // touched files, for UDF input_file_name
// fs.azure.* / fs.s3a.* / fs.gs.* keys captured on the driver from
// sessionState.newHadoopConf() and serialised here so they survive the
// RDD partition boundary. Spark's withSQLConfPropagated only propagates
// keys that start with "spark", so these keys are otherwise invisible on
// the executor side (the executor's SQLConf never sees them).
Comment on lines +41 to +45
fsConf: Map[String, String] = Map.empty
Comment thread
zhouyuan marked this conversation as resolved.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CWE‑532 / CWE‑200:Case‑class auto‑toString prints every field, so any log line or exception that stringifies a partition (or the wrapping FirstZippedPartitionsPartition) will dump fs.s3a.secret.key=… verbatim. Please override toString to print fsConf keys only — or redact values on the driver side at capture time using SECRET_REDACTION_PATTERN (spark.redaction.regex). Note SQLConf.get.stringRedactionPattern is a different config (default None) and won't help here, and SQLConf.get itself isn't safe to call off‑task. Please also add a regression test that asserts toString does not contain a seeded secret value.

I notice Copilot already flagged this security‑related risk earlier. However, the latest commit still hasn’t addressed the issue.

) extends BaseGlutenPartition {

override def preferredLocations(): Array[String] =
Expand Down
Loading