Skip to content

[VL][MINOR] Remove unused bloom filter configs #12002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philo-he merged 2 commits into from
May 8, 2026
Merged

[VL][MINOR] Remove unused bloom filter configs #12002

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b0fc8c
Remove unused configs
acvictor Apr 28, 2026
bff6182
Address PR comments
acvictor May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cpp/velox/config/VeloxConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ const std::string kSparkBloomFilterExpectedNumItems = "spark.sql.optimizer.runti
const std::string kSparkBloomFilterNumBits = "spark.sql.optimizer.runtime.bloomFilter.numBits";
const std::string kSparkBloomFilterMaxNumBits = "spark.sql.optimizer.runtime.bloomFilter.maxNumBits";
const std::string kSparkBloomFilterMaxNumItems = "spark.sql.optimizer.runtime.bloomFilter.maxNumItems";
const std::string kBloomFilterExpectedNumItems = "spark.gluten.sql.columnar.backend.velox.bloomFilter.expectedNumItems";
const std::string kBloomFilterNumBits = "spark.gluten.sql.columnar.backend.velox.bloomFilter.numBits";
Comment thread
acvictor marked this conversation as resolved.
Outdated
const std::string kBloomFilterMaxNumBits = "spark.gluten.sql.columnar.backend.velox.bloomFilter.maxNumBits";
Comment thread
acvictor marked this conversation as resolved.
Outdated
const std::string kVeloxSplitPreloadPerDriver = "spark.gluten.sql.columnar.backend.velox.SplitPreloadPerDriver";
Expand Down
3 changes: 0 additions & 3 deletions gluten-substrait/src/main/scala/org/apache/gluten/config/GlutenConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,9 +480,6 @@ object GlutenConfig extends ConfigRegistry {
SQLConf.RUNTIME_BLOOM_FILTER_MAX_NUM_ITEMS.key,
"spark.io.compression.codec",
"spark.sql.decimalOperations.allowPrecisionLoss",
"spark.gluten.sql.columnar.backend.velox.bloomFilter.expectedNumItems",
"spark.gluten.sql.columnar.backend.velox.bloomFilter.numBits",
"spark.gluten.sql.columnar.backend.velox.bloomFilter.maxNumBits",
// s3 config
SPARK_S3_ACCESS_KEY,
SPARK_S3_SECRET_KEY,
Expand Down
Loading