[VL] Test rebase by zhouyuan · Pull Request #11712 · apache/gluten

zhouyuan · 2026-03-06T09:37:09Z

What changes are proposed in this pull request?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

github-actions · 2026-03-25T09:39:41Z

Run Gluten Clickhouse CI on x86

github-actions · 2026-06-05T02:15:34Z

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Copilot

Pull request overview

Updates the default Velox source/branch used by the Velox backend dependency fetch script (get-velox.sh). This affects the out-of-the-box build path for the Velox backend in Gluten.

Changes:

Changed get-velox.sh default VELOX_REPO from IBM/velox to zhouyuan/velox.
Changed default VELOX_BRANCH to a custom branch name (dft-2026_06_06-fbthrift).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+VELOX_REPO=https://github.com/zhouyuan/velox.git
+VELOX_BRANCH=dft-2026_06_06-fbthrift


Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

.github/workflows/velox_backend_x86.yml:75

This job is still named/cache-keyed/artifact-labeled as “centos-7”, but it now builds inside the vcpkg-centos-9 image and runs the CentOS 9 build script. That mismatch is likely to confuse consumers and can lead to misleading artifacts and cache reuse across different toolchains. Consider renaming the job + cache keys + artifact names (and updating all downstream needs: / download-artifact references) or keep the CentOS 7 image/script here.

          docker run -v $GITHUB_WORKSPACE:/work -w /work apache/gluten:vcpkg-centos-9 bash -c "
            set -e
            yum install tzdata -y
            df -a
            cd /work

+VELOX_REPO=https://github.com/zhouyuan/velox.git
+VELOX_BRANCH=dft-2026_06_06-fbthrift


+	      "fizz",
+        "fbthrift",


Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

+VELOX_REPO=https://github.com/zhouyuan/velox.git
+VELOX_BRANCH=dft-2026_06_06-fbthrift


          "name": "folly",
          "features": ["zstd", "lz4", "lzma", "snappy"]
        },
+	      "fizz",


@@ -77,7 +77,7 @@ jobs:
            export CCACHE_MAXSIZE=1G
            mkdir -p /work/.ccache
            ccache -sz
-            bash dev/ci-velox-buildstatic-centos-7.sh
+            bash dev/ci-velox-buildstatic-centos-9.sh
            ccache -s


Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

+std::unique_ptr<facebook::velox::dwio::common::WriterOptions> makeParquetWriteOption(
    const std::unordered_map<std::string, std::string>& sparkConfs);


Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

 namespace gluten {

-std::unique_ptr<facebook::velox::parquet::WriterOptions> makeParquetWriteOption(
+std::unique_ptr<facebook::velox::dwio::common::WriterOptions> makeParquetWriteOption(


Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

+std::unique_ptr<facebook::velox::dwio::common::WriterOptions> makeParquetWriteOption(
    const std::unordered_map<std::string, std::string>& sparkConfs);


+  const std::shared_ptr<facebook::velox::dwio::common::WriterOptions> writerOptions = makeParquetWriteOption(writeConfs);
  // Spark's default compression code is snappy.
  const auto& compressionKind =
      writerOptions->compressionKind.value_or(common::CompressionKind::CompressionKind_SNAPPY);


Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot wasn't able to review any files in this pull request.

github-actions Bot added BUILD VELOX labels Mar 6, 2026

zhouyuan force-pushed the rebase_iceberg branch 4 times, most recently from 224b8e9 to 947dc98 Compare March 25, 2026 09:39

github-actions Bot added the CORE works for Gluten Core label Mar 25, 2026

zhouyuan force-pushed the rebase_iceberg branch from 947dc98 to 8b7c5bf Compare March 27, 2026 14:49

github-actions Bot removed the CORE works for Gluten Core label Mar 27, 2026

zhouyuan force-pushed the rebase_iceberg branch from b11e9b9 to bdf26c4 Compare March 30, 2026 10:48

zhouyuan force-pushed the rebase_iceberg branch from bdf26c4 to db24436 Compare April 20, 2026 16:11

github-actions Bot added the stale stale label Jun 5, 2026

zhouyuan force-pushed the rebase_iceberg branch from db24436 to cc68cdf Compare June 10, 2026 15:50

Copilot AI review requested due to automatic review settings June 10, 2026 15:50

Copilot started reviewing on behalf of zhouyuan June 10, 2026 15:51 View session

zhouyuan removed the stale stale label Jun 10, 2026

Copilot AI reviewed Jun 10, 2026

View reviewed changes

Comment thread ep/build-velox/src/get-velox.sh Outdated

Comment on lines +20 to +21

VELOX_REPO=https://github.com/zhouyuan/velox.git

VELOX_BRANCH=dft-2026_06_06-fbthrift

zhouyuan force-pushed the rebase_iceberg branch 2 times, most recently from 406a392 to aa10676 Compare June 10, 2026 18:55

Copilot AI review requested due to automatic review settings June 10, 2026 18:55

Copilot started reviewing on behalf of zhouyuan June 10, 2026 18:55 View session

github-actions Bot added the INFRA label Jun 10, 2026

Copilot AI reviewed Jun 10, 2026

View reviewed changes

Comment thread ep/build-velox/src/get-velox.sh Outdated

Comment on lines +20 to +21

VELOX_REPO=https://github.com/zhouyuan/velox.git

VELOX_BRANCH=dft-2026_06_06-fbthrift

Comment thread dev/vcpkg/vcpkg.json

Comment on lines +27 to +28

"fizz",

"fbthrift",

Copilot AI review requested due to automatic review settings June 10, 2026 20:26

zhouyuan force-pushed the rebase_iceberg branch from 96093be to 429f3c6 Compare June 10, 2026 20:26

Copilot started reviewing on behalf of zhouyuan June 10, 2026 20:27 View session

Copilot AI reviewed Jun 10, 2026

View reviewed changes

zhouyuan force-pushed the rebase_iceberg branch from 429f3c6 to bb6d0a5 Compare June 10, 2026 20:55

zhouyuan force-pushed the rebase_iceberg branch from 610ba8c to eac946e Compare June 26, 2026 08:42

Copilot AI review requested due to automatic review settings June 26, 2026 09:02

Copilot started reviewing on behalf of zhouyuan June 26, 2026 09:13 View session

zhouyuan force-pushed the rebase_iceberg branch from 7c5da27 to 38e0f8a Compare June 26, 2026 09:14

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread cpp/velox/utils/VeloxWriterUtils.h Outdated

Comment on lines 26 to 27

std::unique_ptr<facebook::velox::dwio::common::WriterOptions> makeParquetWriteOption(

const std::unordered_map<std::string, std::string>& sparkConfs);

Copilot AI review requested due to automatic review settings June 26, 2026 09:15

Copilot started reviewing on behalf of zhouyuan June 26, 2026 09:20 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread cpp/velox/utils/VeloxWriterUtils.h Outdated

namespace gluten {

std::unique_ptr<facebook::velox::parquet::WriterOptions> makeParquetWriteOption(

std::unique_ptr<facebook::velox::dwio::common::WriterOptions> makeParquetWriteOption(

Copilot AI review requested due to automatic review settings June 26, 2026 09:41

Copilot started reviewing on behalf of zhouyuan June 26, 2026 09:56 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

zhouyuan force-pushed the rebase_iceberg branch from 47bfbc2 to a59117a Compare July 6, 2026 13:42

Copilot AI review requested due to automatic review settings July 17, 2026 07:59

zhouyuan force-pushed the rebase_iceberg branch from a59117a to ef0359e Compare July 17, 2026 07:59

Copilot AI reviewed Jul 17, 2026

github-actions Bot removed the BUILD label Jul 17, 2026

Copilot AI review requested due to automatic review settings July 17, 2026 08:59

Copilot AI reviewed Jul 17, 2026

github-actions Bot added the DOCS label Jul 17, 2026

Copilot AI review requested due to automatic review settings July 17, 2026 10:01

zhouyuan force-pushed the rebase_iceberg branch from f19405b to 62fb666 Compare July 17, 2026 10:01

Copilot AI reviewed Jul 17, 2026

github-actions Bot removed the DOCS label Jul 17, 2026

Copilot AI review requested due to automatic review settings July 17, 2026 10:32

zhouyuan force-pushed the rebase_iceberg branch from 62fb666 to cef9cd1 Compare July 17, 2026 10:32

Copilot AI reviewed Jul 17, 2026

Copilot AI review requested due to automatic review settings July 17, 2026 14:41

zhouyuan closed this Jul 17, 2026

zhouyuan force-pushed the rebase_iceberg branch from cef9cd1 to 0ff7681 Compare July 17, 2026 14:41

Copilot AI reviewed Jul 17, 2026

View reviewed changes

		VELOX_REPO=https://github.com/zhouyuan/velox.git
		VELOX_BRANCH=dft-2026_06_06-fbthrift

		std::unique_ptr<facebook::velox::dwio::common::WriterOptions> makeParquetWriteOption(
		const std::unordered_map<std::string, std::string>& sparkConfs);

Uh oh!

Conversation

zhouyuan commented Mar 6, 2026

What changes are proposed in this pull request?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants