[GLUTEN-11550][UT][Spark4.x] Remove GlutenSingleLevelAggregateHashMapSuite, GlutenTwoLevelAggregateHashMapSuite, GlutenTwoLevelAggregateHashMapWithVectorizedMapSuite#11571
Merged
Conversation
kapilks
changed the title
Contributor
Author
|
@baibaichen Let me know if we still want to retain these suites? |
Contributor
LGTM to remove them. Can we keep a small doc listing the excluded/removed suites (and why), so it’s easier to track and revisit later via AI? |
kapilks
force-pushed
the
fix_glutensinglelevelagg
branch
from
97b3c52 to
69f1f04
Compare
|
Run Gluten Clickhouse CI on x86 |
kapilks
changed the title
kapilks
changed the title
Contributor
Author
|
@baibaichen Please review, added a doc. |
|
Run Gluten Clickhouse CI on x86 |
baibaichen
force-pushed
the
fix_glutensinglelevelagg
branch
from
96b3e52 to
fb28bc8
Compare
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Remove following UTs:
GlutenSingleLevelAggregateHashMapSuite
GlutenTwoLevelAggregateHashMapSuite
GlutenTwoLevelAggregateHashMapWithVectorizedMapSuite
Above suites runs UTs similar to
GlutenDataFrameAggregateSuite. Only difference being that wholestage codegen is enabled or not and multi level aggregation map. These are specific to Spark implementation only.So essentially same as GlutenDataFrameAggregateSuite. So I think these suites would be redundant.
Updated GlutenDataFrameAggregateSuite to add overridden UT for some disables cases.
How was this patch tested?
UTs.
Was this patch authored or co-authored using generative AI tooling?
No
Related issue: #11550