[VL][SPARK-46725] Support dayname function for Spark 4.0+#11549
Closed
yaooqinn wants to merge 2 commits into
Closed
[VL][SPARK-46725] Support dayname function for Spark 4.0+#11549yaooqinn wants to merge 2 commits into
yaooqinn wants to merge 2 commits into
Conversation
|
Run Gluten Clickhouse CI on x86 |
yaooqinn
force-pushed
the
dayname-support
branch
from
d53cb14 to
2bbefc4
Compare
|
Run Gluten Clickhouse CI on x86 |
### What changes were proposed in this pull request? Port Spark's dayname function (SPARK-46725) to Gluten for Spark 4.0 and 4.1. The dayname function returns the three-letter abbreviated day name (Mon, Tue, Wed, etc.) from a date or timestamp. ### How was this patch tested? Added SQL tests in date.sql for both Spark 4.0 and 4.1.
yaooqinn
force-pushed
the
dayname-support
branch
from
2bbefc4 to
acf8196
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Port Spark's
daynamefunction (SPARK-46725) to Gluten for Spark 4.0 and 4.1.The
daynamefunction returns the three-letter abbreviated day name (Mon, Tue, Wed, Thu, Fri, Sat, Sun) from a date or timestamp. This function was introduced in Spark 4.0.0.Changes:
DAY_NAMEconstant (dayname)DayNameexpression mappingGetDateFieldhandling to allowDayNameto useGenericExpressionTransformer(since it returns String, not integer like other extract functions)daynametests indate.sqlfor both Spark 4.0 and 4.1How was this patch tested?
date.sqlinput/output files for Spark 4.0 and 4.1date.sqlinVeloxSQLQueryTestSettingsfor both versionsNote
This is a WIP PR. Velox already supports the
daynamefunction inRegisterDatetime.cpp.