[GLUTEN-11287][VL] Use IWYU tool to check code format

[xinghuayu007]

What changes are proposed in this pull request?

Use IWYU tool to check code format

How was this patch tested?

Related issue: #11287

[philo-he]

Can we enable IWYU in a way embed in cmake? We can enable the check only when code changes are made under cpp/ path.

if(ENABLE_IWYU)
    find_program(IWYU_PATH NAMES include-what-you-use iwyu)
    if(IWYU_PATH)
        set(CMAKE_CXX_INCLUDE_WHAT_YOU_USE ${IWYU_PATH})
    endif()
endif()

[xinghuayu007]

Can we enable IWYU in a way embed in cmake? We can enable the check only when code changes are made under cpp/ path.

if(ENABLE_IWYU)
    find_program(IWYU_PATH NAMES include-what-you-use iwyu)
    if(IWYU_PATH)
        set(CMAKE_CXX_INCLUDE_WHAT_YOU_USE ${IWYU_PATH})
    endif()
endif()

Compiling include-what-you-use needs clang and source code. Currently design can ensure only check modified cpp files.

[philo-he]

Thanks for the update. The current implementation looks a bit complex to me. Do you know how IWYU is enabled in Velox?

[philo-he]

Some comments. Thanks.

[philo-he]

Seems no need to add a new build option. Just let the compilation depend on the setting for CC and CXX in the env.

[philo-he]

To separate the builds, we can run ./dev/builddeps-veloxbe.sh build_velox xxx with gcc to utilize vcpkg cache in docker. Then, run ./dev/builddeps-veloxbe.sh build_gluten_cpp with clang to build Gluten c++ code.

[philo-he]

Errors reported by CI.

/usr/bin/clang++: /lib64/libtinfo.so.5: no version information available (required by /usr/bin/clang++)
/__w/gluten/gluten/cpp/velox/jni/VeloxJniWrapper.cc:1042:24: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
 1042 |       otherTables[t] = std::move(hashTableBuilders[t]->uniqueTable());
      |                        ^
/__w/gluten/gluten/cpp/velox/jni/VeloxJniWrapper.cc:1042:24: note: remove std::move call here
 1042 |       otherTables[t] = std::move(hashTableBuilders[t]->uniqueTable());
      |                        ^~~~~~~~~~                                   ~
1 error generated.
[57/94] Building CXX object velox/CMakeFiles/velox.dir/memory/VeloxMemoryManager.cc.o
/usr/bin/clang++: /lib64/libtinfo.so.5: no version information available (required by /usr/bin/clang++)
[58/94] Building CXX object velox/CMakeFiles/velox.dir/memory/VeloxColumnarBatch.cc.o
/usr/bin/clang++: /lib64/libtinfo.so.5: no version information available (required by /usr/bin/clang++)
[59/94] Building CXX object velox/CMakeFiles/velox.dir/operators/functions/RegistrationAllFunctions.cc.o
/usr/bin/clang++: /lib64/libtinfo.so.5: no version information available (required by /usr/bin/clang++)
ninja: build stopped: subcommand failed.

[xinghuayu007]

Errors reported by CI.

/usr/bin/clang++: /lib64/libtinfo.so.5: no version information available (required by /usr/bin/clang++)
/__w/gluten/gluten/cpp/velox/jni/VeloxJniWrapper.cc:1042:24: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
 1042 |       otherTables[t] = std::move(hashTableBuilders[t]->uniqueTable());
      |                        ^
/__w/gluten/gluten/cpp/velox/jni/VeloxJniWrapper.cc:1042:24: note: remove std::move call here
 1042 |       otherTables[t] = std::move(hashTableBuilders[t]->uniqueTable());
      |                        ^~~~~~~~~~                                   ~
1 error generated.
[57/94] Building CXX object velox/CMakeFiles/velox.dir/memory/VeloxMemoryManager.cc.o
/usr/bin/clang++: /lib64/libtinfo.so.5: no version information available (required by /usr/bin/clang++)
[58/94] Building CXX object velox/CMakeFiles/velox.dir/memory/VeloxColumnarBatch.cc.o
/usr/bin/clang++: /lib64/libtinfo.so.5: no version information available (required by /usr/bin/clang++)
[59/94] Building CXX object velox/CMakeFiles/velox.dir/operators/functions/RegistrationAllFunctions.cc.o
/usr/bin/clang++: /lib64/libtinfo.so.5: no version information available (required by /usr/bin/clang++)
ninja: build stopped: subcommand failed.

Thanks. Done.

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions]

This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.