Skip to content

[GLUTEN-11283][VL] Respect spark default zstd compression level #11284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philo-he merged 2 commits into from
Dec 16, 2025
Merged

[GLUTEN-11283][VL] Respect spark default zstd compression level #11284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1125de4
[GLUTEN-11283][VL] Respect spark default zstd compression level
wecharyu Dec 11, 2025
ef6f0d2
Merge branch 'main' into GLUTEN-11283
FelixYBW Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions cpp/velox/utils/VeloxWriterUtils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ using namespace facebook::velox::common;

namespace {
const int32_t kGzipWindowBits4k = 12;
}
const int32_t kZSTDDefaultCompressionLevel = 3;
} // namespace

std::unique_ptr<WriterOptions> makeParquetWriteOption(const std::unordered_map<std::string, std::string>& sparkConfs) {
int64_t maxRowGroupBytes = 134217728; // 128MB
Expand Down Expand Up @@ -73,12 +74,11 @@ std::unique_ptr<WriterOptions> makeParquetWriteOption(const std::unordered_map<s
compressionCodec = CompressionKind::CompressionKind_LZ4;
} else if (boost::iequals(compressionCodecStr, "zstd")) {
compressionCodec = CompressionKind::CompressionKind_ZSTD;
if (auto it = sparkConfs.find(kParquetZSTDCompressionLevel); it != sparkConfs.end()) {
auto compressionLevel = std::stoi(it->second);
auto codecOptions = std::make_shared<parquet::arrow::util::CodecOptions>();
codecOptions->compression_level = compressionLevel;
writeOption->codecOptions = std::move(codecOptions);
}
auto codecOptions = std::make_shared<parquet::arrow::util::CodecOptions>();
auto it = sparkConfs.find(kParquetZSTDCompressionLevel);
auto compressionLevel = it != sparkConfs.end() ? std::stoi(it->second) : kZSTDDefaultCompressionLevel;
codecOptions->compression_level = compressionLevel;
writeOption->codecOptions = std::move(codecOptions);
} else if (boost::iequals(compressionCodecStr, "uncompressed")) {
compressionCodec = CompressionKind::CompressionKind_NONE;
} else if (boost::iequals(compressionCodecStr, "none")) {
Expand Down