[GLUTEN-10933][VL] Support resize GPU batch and shuffle reader outputs cudf::table by jinchengchenghh · Pull Request #11090 · apache/gluten

jinchengchenghh · 2025-11-14T14:41:43Z

Now in the post rule, we can only get the stage level plan, so we cannot decide if the ColumnarExchange output should be cudf format, currently, we suppose the ColumnarExchange is always CudfColumnarExchange, will support validation in injectQueryStagePrepRule where we can see the total plan, generated the transformed plan and validate it, then discard it.
After CudfColumnarExchange, concat the batches in GpuResizeBufferColumnarBatchExec to output cudf::table with batch size maximum integer, velox-cudf does not control the batch size now. So the CPU shuffle reader does the decompression and prepare the first batch while GPU executes the CPU tasks one by one.
Performance:
After this change, the stage 2 in TPCDS Q95 SF100 time decreases from 27s to 13s.

In the shuffle writer, split the bool to byte, and timestamp to nanoseconds int64_t to match the cudf format.
Now BroadcastExchange outputs RowVector, so the CudfFromVeclox operator should accept RowVector and CudfVector with this commit, oap-project/velox@3d6ab40

Also fix the Gluten build with GPU.

Related issue: #10933

github-actions · 2025-11-14T14:42:12Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-14T15:06:10Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-14T15:22:50Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-14T15:24:50Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-14T15:27:17Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-14T19:31:26Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-14T20:01:15Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-14T21:37:05Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-17T10:51:31Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-17T12:00:38Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-17T13:50:30Z

Run Gluten ClickHouse CI on ARM

jinchengchenghh · 2025-11-20T11:00:39Z

Could you help review this PR? Thanks! @marin-ma @zhztheplayer

marin-ma

Just left some comments. Thanks!

marin-ma · 2025-11-20T12:41:30Z

@@ -171,6 +171,17 @@ class ColumnarShuffleWriter[K, V](
              conf.get(SHUFFLE_SORT_USE_RADIXSORT),
              partitionWriterHandle
            )
+          } else if (dep.shuffleWriterType == GpuHashShuffleWriterType) {


nit: use if(dep.shuffleWriterType == SortShuffleWriterType) in the condition branch above

Do you mean change the L162? This looks like not related to this PR?

marin-ma · 2025-11-20T12:50:09Z

@@ -20,6 +20,10 @@
 #include "shuffle/VeloxRssSortShuffleWriter.h"
 #include "shuffle/VeloxSortShuffleWriter.h"

+#ifdef GLUTEN_ENABLE_GPU
+#include "GpuShuffleWriter.h"


nit: #include "shuffle/GpuShuffleWriter.h"

Should we name it as VeloxGpuShuffleWriter to align the naming with the existing shuffle writer types?

marin-ma · 2025-11-20T12:51:21Z

+ * limitations under the License.
+ */
+
+#include "GpuShuffleWriter.h"


marin-ma · 2025-11-20T12:52:02Z

+
+#pragma once
+
+#include "VeloxHashShuffleWriter.h"


marin-ma · 2025-11-20T12:56:39Z

+
+namespace gluten {
+
+class GpuBufferBatchResizer : public ColumnarBatchIterator {


It would be nice to have some cpp unit test for the functionality of this class.

It is in VeloxGpuShuffleWriterTest https://github.com/apache/incubator-gluten/pull/11090/files#diff-54f34ba7d66ecb2863b96eb60ffb3a49823d8880ec280d80499fc9c759478a12R113

github-actions · 2025-11-20T13:42:47Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-20T16:36:03Z

Run Gluten ClickHouse CI on ARM

zhouyuan · 2025-11-20T17:10:29Z

Run Gluten ClickHouse CI on X86

github-actions · 2025-11-21T11:31:10Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-21T11:32:53Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-21T11:33:32Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-21T13:08:34Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-21T13:48:57Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-21T13:50:17Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-21T13:59:14Z

Run Gluten ClickHouse CI on ARM

github-actions · 2025-11-21T14:01:48Z

Run Gluten ClickHouse CI on ARM

jinchengchenghh · 2025-11-24T10:21:11Z

Do you have further comments? @marin-ma

jinchengchenghh · 2025-11-25T10:55:31Z

Run Gluten ClickHouse CI on X86

marin-ma

Thanks!

marin-ma · 2025-11-25T11:05:13Z

-    BackendsApiManager.getSparkPlanExecApiInstance.getShuffleWriterType(outputPartitioning, output)
+  lazy val shuffleWriterType: ShuffleWriterType = getShuffleWriterType
+
+  // super.stringArgs ++ Iterator(output.map(o => s"${o}#${o.dataType.simpleString}"))


Looks like an outdated comment. Could you remove?

…r outputs cudf::table (apache#11090)" This reverts commit 157b96e.

github-actions Bot added CORE works for Gluten Core VELOX labels Nov 14, 2025

github-actions Bot added the INFRA label Nov 14, 2025

github-actions Bot added the BUILD label Nov 14, 2025

jinchengchenghh commented Nov 14, 2025

View reviewed changes

Comment thread cpp/velox/utils/GpuBufferBatchResizer.cc Outdated

jinchengchenghh force-pushed the shuffleup branch from 17f23d0 to a37f84f Compare November 17, 2025 10:51

github-actions Bot added the DOCS label Nov 17, 2025

jinchengchenghh changed the title ~~[GLUTEN-10933][VL] Support resize GPU batch~~ [GLUTEN-10933][VL] Support resize GPU batch and shuffle reader outputs cudf::table Nov 17, 2025

jinchengchenghh requested review from marin-ma and zhztheplayer November 17, 2025 16:12

marin-ma reviewed Nov 20, 2025

View reviewed changes

jinchengchenghh force-pushed the shuffleup branch from 2cd677b to 7a304f8 Compare November 20, 2025 13:42

jinchengchenghh force-pushed the shuffleup branch from c5f37cd to 744d564 Compare November 21, 2025 11:33

[GLUTEN-10933][VL] Support resize GPU batch

89c5c6a

jinchengchenghh force-pushed the shuffleup branch from 7633f06 to 89c5c6a Compare November 21, 2025 13:49

fix

51099e9

fix

71f7e48

marin-ma approved these changes Nov 25, 2025

View reviewed changes

marin-ma reviewed Nov 25, 2025

View reviewed changes

jinchengchenghh merged commit 157b96e into apache:main Nov 25, 2025
105 of 109 checks passed

jinchengchenghh mentioned this pull request Jan 19, 2026

[GLUTEN-10933][VL] BroadcastExchange outputs cudf::table #11441

Merged

jinchengchenghh added a commit to jinchengchenghh/gluten that referenced this pull request Jan 20, 2026

Revert "[GLUTEN-10933][VL] Support resize GPU batch and shuffle reade…

0587bab

…r outputs cudf::table (apache#11090)" This reverts commit 157b96e.


		namespace gluten {

		class GpuBufferBatchResizer : public ColumnarBatchIterator {

Uh oh!

Conversation

jinchengchenghh commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 14, 2025

Uh oh!

github-actions Bot commented Nov 14, 2025

Uh oh!

github-actions Bot commented Nov 14, 2025

Uh oh!

github-actions Bot commented Nov 14, 2025

Uh oh!

github-actions Bot commented Nov 14, 2025

Uh oh!

Uh oh!

github-actions Bot commented Nov 14, 2025

Uh oh!

github-actions Bot commented Nov 14, 2025

Uh oh!

github-actions Bot commented Nov 14, 2025

Uh oh!

github-actions Bot commented Nov 17, 2025

Uh oh!

github-actions Bot commented Nov 17, 2025

Uh oh!

github-actions Bot commented Nov 17, 2025

Uh oh!

jinchengchenghh commented Nov 20, 2025

Uh oh!

marin-ma left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Nov 20, 2025

Uh oh!

github-actions Bot commented Nov 20, 2025

Uh oh!

zhouyuan commented Nov 20, 2025

Uh oh!

github-actions Bot commented Nov 21, 2025

Uh oh!

github-actions Bot commented Nov 21, 2025

Uh oh!

github-actions Bot commented Nov 21, 2025

Uh oh!

github-actions Bot commented Nov 21, 2025

Uh oh!

github-actions Bot commented Nov 21, 2025

Uh oh!

github-actions Bot commented Nov 21, 2025

Uh oh!

github-actions Bot commented Nov 21, 2025

Uh oh!

github-actions Bot commented Nov 21, 2025

Uh oh!

jinchengchenghh commented Nov 24, 2025

Uh oh!

jinchengchenghh commented Nov 25, 2025

Uh oh!

marin-ma left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

jinchengchenghh commented Nov 14, 2025 •

edited

Loading