[GLUTEN-4039][VL] Enable map_from_arrays function with Velox backend#10058
Closed
dmsuehir wants to merge 8 commits into
Closed
[GLUTEN-4039][VL] Enable map_from_arrays function with Velox backend#10058dmsuehir wants to merge 8 commits into
dmsuehir wants to merge 8 commits into
Conversation
Signed-off-by: Dina Suehiro Jones <dina.s.jones@intel.com>
Signed-off-by: Dina Suehiro Jones <dina.s.jones@intel.com>
Signed-off-by: Dina Suehiro Jones <dina.s.jones@intel.com>
Contributor
|
@dmsuehir can you check if it's supported? may be facebookincubator/velox#10280 is blocker for this |
Contributor
Author
@nimesh1601 Thank you for raising that issue. I can wait for that PR to be merged. |
Signed-off-by: Dina Suehiro Jones <dina.s.jones@intel.com>
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR enables the
map_from_arraysfunction through the Velox backend, as it appears to be supported in the Velox documentation.(Fixes: #4039)
How was this patch tested?
After removing
map_from_arraysfrom the exclusion list, I ran thegen-function-support-docs.pyscript (which runs unit tests to verify which functions are unsupported). That generated the Velox doc update which show thatmap_from_arraysis supported. I also added a scala test exercisingmap_from_arrays.