GEODE-10256: HttpSessionListener is not working #7619
Conversation
masaki-yamakawa
requested review from
BenjaminPerryRoss,
jake-at-work and
jdeppe-pivotal
as code owners
There was a problem hiding this comment.
I would like to get some more info regarding this issue. I've left a comment on the ticket here: https://issues.apache.org/jira/browse/GEODE-10256
|
@jdeppe-pivotal |
| testImplementation('org.mockito:mockito-core') | ||
| testImplementation('org.apache.tomcat:catalina-ha:' + DependencyConstraints.get('tomcat6.version')) | ||
|
|
||
| testImplementation(project(':geode-junit')) { |
There was a problem hiding this comment.
I don't see what symbol from geode-junit is being used to require this addition.
|
@masaki-yamakawa: I know this has been dormant for quite some time, but @JinwooHwang and I are reviewing backlogged pull requests and I wanted to check with you about this contribution. We're wondering if you're still interested in seeing it merged. I think the work is valuable but I defer to your judgement on whether you believe the contribution is stale by this point. |
|
@semioticrobotic thanks for checking in. I’m still interested in seeing this merged. I’ll review the branch, address any remaining comments or conflicts, and push an update to the PR. If you’d prefer this be closed instead, please let me know. |
Great, @masaki-yamakawa! On the contrary: We'd much prefer to see it through to fruition! Best of luck, and thanks. |
3 participants
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
[-] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?