[client][hotfix] Invoke RowType#getFieldNames only once in ConverterCommons
#1920
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snuyanzin
commented
Oct 31, 2025
| pojoNames, fieldNames)); | ||
| } | ||
| for (int i = 0; i < tableSchema.getFieldCount(); i++) { | ||
| String name = tableSchema.getFieldNames().get(i); |
Contributor
Author
There was a problem hiding this comment.
Avoid calling it inside a loop since each call generates a new collection
fluss/fluss-common/src/main/java/org/apache/fluss/types/RowType.java
Lines 66 to 68 in 84b06ac
Contributor
Author
|
fyi @polyzos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
It is a small optimization to avoid calling
RowType#getFieldNamesinside a loop since each time it should through fields and create a new collection of namesBrief change log
Tests
API and Format
Documentation