Skip to content

Fix thread-safety problem of PrimaryKeyLoookuper and PrefixKeyLookuper #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix thread-safety problem of PrimaryKeyLoookuper and PrefixKeyLookuper #1915

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ec6e33
fix thread-safety problem of PrimaryKeyLoookuper and PrefixKeyLookuper
platinumhamburg Oct 31, 2025
94ad89d
make lookup retries thread safety
platinumhamburg Nov 5, 2025
49e56c0
refact
platinumhamburg Nov 5, 2025
443c9a2
fix compile issue
platinumhamburg Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fluss-client/src/main/java/org/apache/fluss/client/lookup/PrefixKeyLookuper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ private void validatePrefixLookup(TableInfo tableInfo, List<String> lookupColumn
}

@Override
public CompletableFuture<LookupResult> lookup(InternalRow prefixKey) {
public synchronized CompletableFuture<LookupResult> lookup(InternalRow prefixKey) {
byte[] bucketKeyBytes = bucketKeyEncoder.encodeKey(prefixKey);
int bucketId = bucketingFunction.bucketing(bucketKeyBytes, numBuckets);

Expand Down
2 changes: 1 addition & 1 deletion fluss-client/src/main/java/org/apache/fluss/client/lookup/PrimaryKeyLookuper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public PrimaryKeyLookuper(
}

@Override
public CompletableFuture<LookupResult> lookup(InternalRow lookupKey) {
public synchronized CompletableFuture<LookupResult> lookup(InternalRow lookupKey) {
// encoding the key row using a compacted way consisted with how the key is encoded when put
// a row
byte[] pkBytes = primaryKeyEncoder.encodeKey(lookupKey);
Expand Down