[python] Add stub test to catch pyi drift in CI - #616
Merged
Conversation
charlesdong1991
changed the title
charlesdong1991
commented
Jun 10, 2026
|
|
||
| stubtest: | ||
| # For stub tests, we only needs the module importable, so no | ||
| # test cluster is started and a single Python version should be sufficient. |
Contributor
Author
There was a problem hiding this comment.
i think 1 version is enough for stub test, so no need to put to matrix to test across all versions... but no strong opinion
Contributor
Author
|
cc @fresh-borzoni @leekeiabstraction let me know what you think? 🙏 |
fresh-borzoni
approved these changes
Jun 10, 2026
fresh-borzoni
left a comment
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@charlesdong1991 Thank you for the PR, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #610 (comment)
Add subtest in CI to avoid .pyi drifts