[metrics] Add scanner poll-timing metrics - #555
Merged
fresh-borzoni merged 6 commits intoMay 26, 2026
Conversation
Contributor
Author
|
@fresh-borzoni @leekeiabstraction appreciate if you can give. a look! 🙏 |
Member
|
@charlesdong1991 Ty for the PR! |
Contributor
Author
|
@fresh-borzoni resolved! ^^ |
fresh-borzoni
left a comment
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@charlesdong1991 Ty for the PR, LGTM overall, minor comments
2 tasks
Contributor
Author
|
thanks for reviews @fresh-borzoni PTAL 🙏 |
fresh-borzoni
approved these changes
May 26, 2026
fresh-borzoni
left a comment
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@charlesdong1991 TY, LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds the two viable poll-timing gauges.
Note that it doesn't implement
lastPollSecondsAgometric because it will require a different emission mechasnim, so better to separate implementations in different PRs. I created an issue here: #554Linked issue: close #552
Brief change log
Tests
All passed locally.
API and Format
Documentation