Skip to content

[ci] use swatinem/rust-cache - #485

Merged
luoyuxia merged 5 commits into
apache:mainfrom
fresh-borzoni:chore/swatinem-rust-cache
Apr 11, 2026
Merged

[ci] use swatinem/rust-cache#485
luoyuxia merged 5 commits into
apache:mainfrom
fresh-borzoni:chore/swatinem-rust-cache

Conversation

@fresh-borzoni

Copy link
Copy Markdown
Member

Summary

closes #484

Replace actions/cache with Swatinem/rust-cache to prevent cargo cache eviction across CI workflows.

@fresh-borzoni

Copy link
Copy Markdown
Member Author

@leekeiabstraction PTAL 🙏

@leekeiabstraction leekeiabstraction left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY for the PR, left a comment.

Comment thread .github/workflows/build_and_test_python.yml Outdated
@fresh-borzoni

Copy link
Copy Markdown
Member Author

@leekeiabstraction Ty for the review, yes it's in allowlist, pinned v2 commit 👍

Comment thread .github/workflows/build_and_test_cpp.yml Outdated
@fresh-borzoni

Copy link
Copy Markdown
Member Author

@leekeiabstraction now it should be at the latest tag, ty for spotting

@fresh-borzoni

Copy link
Copy Markdown
Member Author

fixed uv sync here as well, we don't need to sync two times

@fresh-borzoni

Copy link
Copy Markdown
Member Author

@leekeiabstraction fixed, would you mind to rerun?

@fresh-borzoni

fresh-borzoni commented Apr 10, 2026

Copy link
Copy Markdown
Member Author

Good news, the optimizations works as a charm, but it seems that merged code has a bug in python 3.11, so I prepared a fix #488

@fresh-borzoni
fresh-borzoni force-pushed the chore/swatinem-rust-cache branch from 8ac93ce to 9fda112 Compare April 10, 2026 22:17
@fresh-borzoni

Copy link
Copy Markdown
Member Author

rebased

@luoyuxia luoyuxia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for take it care. LGTM

@luoyuxia
luoyuxia merged commit 74d88cd into apache:main Apr 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ci] use more efficient cache

3 participants