[test][infra] Unify IT infrastructure for all clients - #476
Merged
leekeiabstraction merged 5 commits intoApr 9, 2026
Conversation
Member
Author
|
@luoyuxia @leekeiabstraction PTAL 🙏 |
fresh-borzoni
force-pushed
the
feat/unified-test-cluster
branch
from
April 5, 2026 15:32
9ca49b5 to
5dc1ed9
Compare
Member
Author
|
@leekeiabstraction Would you mind to rerun? |
Member
Author
fresh-borzoni
force-pushed
the
feat/unified-test-cluster
branch
from
April 5, 2026 21:29
37dffd3 to
a72eb8a
Compare
Member
Author
|
@leekeiabstraction rebased |
Member
Author
|
@leekeiabstraction rerun is still much appreciated to understand if cache works, ty |
Contributor
|
Retriggered CI workflows |
leekeiabstraction
left a comment
leekeiabstraction
left a comment
Contributor
There was a problem hiding this comment.
TY for the PR. Left some comments. PTAL
Member
Author
|
@leekeiabstraction Ty for the review, addressed comments, PTAL 🙏 |
leekeiabstraction
approved these changes
Apr 9, 2026
leekeiabstraction
left a comment
leekeiabstraction
left a comment
Contributor
There was a problem hiding this comment.
LGTM, TY for the PR!
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #393 #394
All three language bindings (Rust, Python, C++) previously had their own Docker cluster management, each with hardcoded image versions, container naming, SASL configuration, and readiness checks. Bugs had to be found and fixed in each implementation independently.
This PR extracts the shared logic into a fluss-test-cluster crate that produces both a library (used by Rust tests directly) and a CLI binary (used by Python and C++ via subprocess). The CLI's start command is idempotent: it starts containers if needed, waits for readiness, and prints cluster addresses as JSON to stdout. The stop command tears everything down.
Python's conftest.py calls the CLI, parses the JSON, and wires up pytest fixtures. The filelock package serializes xdist workers so only one starts the cluster.
C++ test_utils.h follows the same pattern: call CLI, parse JSON with nlohmann/json, connect via GoogleTest environment.
Rust tests use the library directly through a LazyLock singleton, no CLI needed.