[BUG] Stale cluster state in Lookuper lookup - #451
Merged
Conversation
Member
Author
fresh-borzoni
changed the title
fresh-borzoni
changed the title
fresh-borzoni
changed the title
leekeiabstraction
approved these changes
Mar 28, 2026
leekeiabstraction
left a comment
leekeiabstraction
left a comment
Contributor
There was a problem hiding this comment.
TY for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lookuper::lookup()captures a cluster state before callingleader_for(), then uses that state to resolve the leader's server. Ifleader_for()refreshed metadata internally (cache miss -> coordinator RPC), the returned leader could reference a server absent from the stale state, causing a spurious "server not found" error during leader transitions.Proposed fix: connect to the ServerNode returned by
leader_for()directly as it already contains host and port.Removes the redundant cluster state lookup and the race entirely.