-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[FLINK-37746] Added serialVersionUID in MapTypeInfo class #26515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@@ -39,6 +39,8 @@ | |||
@PublicEvolving | |||
public class MapTypeInfo<K, V> extends TypeInformation<Map<K, V>> { | |||
|
|||
private static final long serialVersionUID = 8239116190285601804L; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: why not 1L like the value and list versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay will change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidradl Does it exist compatibility problem if we set UID = 1L because the old version has use the framework auto generated UID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
LGTM.
What is the purpose of the change
Adding serialVersionUID in MapTypeInfo class
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: YesDocumentation